[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 3/7] vhost: New memory update functions
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [RFC 3/7] vhost: New memory update functions |
Date: |
Wed, 29 Nov 2017 18:50:22 +0000 |
From: "Dr. David Alan Gilbert" <address@hidden>
vhost_update_mem will replace the existing update mechanism.
They make use of the Flatview we have now to make the update simpler.
This commit just adds the basic structure.
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
hw/virtio/vhost.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 938253d1e8..c959a59fb3 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c
@@ -629,6 +629,43 @@ static void vhost_begin(MemoryListener *listener)
dev->mem_changed_start_addr = -1;
}
+struct vhost_update_mem_tmp {
+ struct vhost_dev *dev;
+ uint32_t nregions;
+ struct vhost_memory_region *regions;
+};
+
+/* Called for each MRS from vhost_update_mem */
+static int vhost_update_mem_cb(MemoryRegionSection *mrs, void *opaque)
+{
+ if (!vhost_section(mrs)) {
+ return 0;
+ }
+
+ /* TODO */
+ return 0;
+}
+
+static int vhost_update_mem(struct vhost_dev *dev)
+{
+ int res;
+ struct vhost_update_mem_tmp vtmp;
+ vtmp.regions = 0;
+ vtmp.nregions = 0;
+ vtmp.dev = dev;
+
+ res = address_space_iterate(&address_space_memory,
+ vhost_update_mem_cb, &vtmp);
+ if (res) {
+ goto out;
+ }
+
+ /* TODO */
+out:
+ g_free(vtmp.regions);
+ return res;
+}
+
static void vhost_commit(MemoryListener *listener)
{
struct vhost_dev *dev = container_of(listener, struct vhost_dev,
@@ -648,6 +685,10 @@ static void vhost_commit(MemoryListener *listener)
return;
}
+ if (vhost_update_mem(dev)) {
+ return;
+ }
+
if (dev->started) {
start_addr = dev->mem_changed_start_addr;
size = dev->mem_changed_end_addr - dev->mem_changed_start_addr + 1;
@@ -1523,6 +1564,9 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice
*vdev)
goto fail_features;
}
+ if (vhost_update_mem(hdev)) {
+ goto fail_mem;
+ }
if (vhost_dev_has_iommu(hdev)) {
memory_listener_register(&hdev->iommu_listener, vdev->dma_as);
}
--
2.14.3
- [Qemu-devel] [RFC 0/7] Rework vhost memory region updates, Dr. David Alan Gilbert (git), 2017/11/29
- [Qemu-devel] [RFC 1/7] memory: address_space_iterate, Dr. David Alan Gilbert (git), 2017/11/29
- [Qemu-devel] [RFC 2/7] vhost: Move log_dirty check, Dr. David Alan Gilbert (git), 2017/11/29
- [Qemu-devel] [RFC 3/7] vhost: New memory update functions,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [RFC 5/7] vhost: Compare new and old memory lists, Dr. David Alan Gilbert (git), 2017/11/29
- [Qemu-devel] [RFC 4/7] vhost: update_mem_cb implementation, Dr. David Alan Gilbert (git), 2017/11/29
- [Qemu-devel] [RFC 7/7] vhost: Remove vhost_set_memory and children, Dr. David Alan Gilbert (git), 2017/11/29
- [Qemu-devel] [RFC 6/7] vhost: Copy updated region data into device state, Dr. David Alan Gilbert (git), 2017/11/29
- Re: [Qemu-devel] [RFC 0/7] Rework vhost memory region updates, Igor Mammedov, 2017/11/30