[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qemu] vfio-pci: Remove unused fields from VFIOMS
From: |
Alexey Kardashevskiy |
Subject: |
Re: [Qemu-devel] [PATCH qemu] vfio-pci: Remove unused fields from VFIOMSIXInfo |
Date: |
Thu, 30 Nov 2017 12:56:09 +1100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 30/11/17 02:36, Alex Williamson wrote:
> On Wed, 22 Nov 2017 18:39:47 +1100
> Alexey Kardashevskiy <address@hidden> wrote:
>
> Missing reference to commit that made these fields unused. A Fixes tag
> to that commit also seems appropriate. An empty commit log is pretty
> much never justified.
Ah. Right, sorry. I could not find when it was used, looks like never.
> This also looks like 2.12 material. Thanks,
Indeed 2.12.
>
> Alex
>
>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>> ---
>> hw/vfio/pci.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h
>> index c5e168e..06dcf99 100644
>> --- a/hw/vfio/pci.h
>> +++ b/hw/vfio/pci.h
>> @@ -93,8 +93,6 @@ typedef struct VFIOMSIXInfo {
>> uint16_t entries;
>> uint32_t table_offset;
>> uint32_t pba_offset;
>> - MemoryRegion mmap_mem;
>> - void *mmap;
>> unsigned long *pending;
>> } VFIOMSIXInfo;
>>
>
--
Alexey