[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [qemu-s390x] [PATCH v2 for-2.12 16/16] s390x/tcg: drop
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [qemu-s390x] [PATCH v2 for-2.12 16/16] s390x/tcg: drop potential_page_fault() |
Date: |
Thu, 30 Nov 2017 13:02:54 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 29.11.2017 21:27, David Hildenbrand wrote:
> Only one user left, get rid of it so we don't get any new users.
>
> Reviewed-by: Richard Henderson <address@hidden>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> target/s390x/translate.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/target/s390x/translate.c b/target/s390x/translate.c
> index 1ce1390699..26cf993405 100644
> --- a/target/s390x/translate.c
> +++ b/target/s390x/translate.c
> @@ -240,12 +240,6 @@ static void update_cc_op(DisasContext *s)
> }
> }
>
> -static void potential_page_fault(DisasContext *s)
> -{
> - update_psw_addr(s);
> - update_cc_op(s);
> -}
> -
> static inline uint64_t ld_code2(CPUS390XState *env, uint64_t pc)
> {
> return (uint64_t)cpu_lduw_code(env, pc);
> @@ -2939,7 +2933,8 @@ static ExitStatus op_lpd(DisasContext *s, DisasOps *o)
>
> /* In a parallel context, stop the world and single step. */
> if (tb_cflags(s->tb) & CF_PARALLEL) {
> - potential_page_fault(s);
> + update_psw_addr(s);
> + update_cc_op(s);
> gen_exception(EXCP_ATOMIC);
> return EXIT_NORETURN;
> }
>
Reviewed-by: Thomas Huth <address@hidden>
- Re: [Qemu-devel] [PATCH v2 for-2.12 11/16] s390x/tcg: use s390_program_interrupt() in DIAG, (continued)
- [Qemu-devel] [PATCH v2 for-2.12 12/16] s390x/tcg: use s390_program_interrupt() in per_check_exception(), David Hildenbrand, 2017/11/29
- [Qemu-devel] [PATCH v2 for-2.12 13/16] s390x/tcg: use s390_program_interrupt() in SACF, David Hildenbrand, 2017/11/29
- [Qemu-devel] [PATCH v2 for-2.12 14/16] s390x/tcg: use s390_program_interrupt() in STSI, David Hildenbrand, 2017/11/29
- [Qemu-devel] [PATCH v2 for-2.12 15/16] s390x/tcg: drop program_interrupt(), David Hildenbrand, 2017/11/29
- [Qemu-devel] [PATCH v2 for-2.12 16/16] s390x/tcg: drop potential_page_fault(), David Hildenbrand, 2017/11/29
- Re: [Qemu-devel] [qemu-s390x] [PATCH v2 for-2.12 16/16] s390x/tcg: drop potential_page_fault(),
Thomas Huth <=