[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size para
From: |
Richard W.M. Jones |
Subject: |
Re: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter |
Date: |
Sat, 2 Dec 2017 11:35:41 +0000 |
User-agent: |
Mutt/1.5.20 (2009-12-10) |
On Fri, Dec 01, 2017 at 04:15:38PM +0100, Eric Farman wrote:
> Commit 5c0919d02066 ("virtio-scsi: Add virtqueue_size parameter allowing
> virtqueue size to be set.") introduced a new parameter to virtio-scsi.
> Later, commit 920036106044 ("vhost-user-scsi: add missing virtqueue_size
> param") added that parameter to the new vhost-user-scsi interface but
> neglected the existing vhost-scsi interface it was built on.
>
> Apply the same change to vhost-scsi, so that we can boot a guest with
> a device defined. This also avoids crashing a guest when hotplugging
> a vhost-scsi device.
>
> Signed-off-by: Eric Farman <address@hidden>
> ---
> hw/scsi/vhost-scsi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
> index cd4ab05233..9c1bea8ff3 100644
> --- a/hw/scsi/vhost-scsi.c
> +++ b/hw/scsi/vhost-scsi.c
> @@ -233,6 +233,8 @@ static Property vhost_scsi_properties[] = {
> DEFINE_PROP_STRING("wwpn", VirtIOSCSICommon, conf.wwpn),
> DEFINE_PROP_UINT32("boot_tpgt", VirtIOSCSICommon, conf.boot_tpgt, 0),
> DEFINE_PROP_UINT32("num_queues", VirtIOSCSICommon, conf.num_queues, 1),
> + DEFINE_PROP_UINT32("virtqueue_size", VirtIOSCSICommon,
> conf.virtqueue_size,
> + 128),
> DEFINE_PROP_UINT32("max_sectors", VirtIOSCSICommon, conf.max_sectors,
> 0xFFFF),
> DEFINE_PROP_UINT32("cmd_per_lun", VirtIOSCSICommon, conf.cmd_per_lun,
> 128),
Yes, this fix is fine. Sorry for breaking it :-/
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html
- [Qemu-devel] [PATCH for 2.11 0/1] Fix guest boot with vhost-scsi, Eric Farman, 2017/12/01
- [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter, Eric Farman, 2017/12/01
- Re: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter, Paolo Bonzini, 2017/12/01
- Re: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter, Eric Farman, 2017/12/04
- Re: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter, Peter Maydell, 2017/12/04
- Re: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter, Eric Farman, 2017/12/04
- Re: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter, Michael S. Tsirkin, 2017/12/04
- Re: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter, Peter Maydell, 2017/12/05
- Re: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter, Eric Farman, 2017/12/05
Re: [Qemu-devel] [PATCH 1/1] vhost-scsi: add missing virtqueue_size parameter,
Richard W.M. Jones <=