Re: [Qemu-devel] [PATCH 11/25] spapr: describe the XIVE interrupt source flags

[Benjamin Herrenschmidt]

On Tue, 2017-11-28 at 17:40 +1100, David Gibson wrote:
> > @@ -368,6 +368,10 @@ static void spapr_xive_realize(DeviceState *dev, Error 
> > **errp)
> >      /* Allocate the IVT (Interrupt Virtualization Table) */
> >      xive->ivt = g_malloc0(xive->nr_irqs * sizeof(XiveIVE));
> >  
> > +    /* All sources are emulated under the XIVE object and share the
> > +     * same characteristic */
> > +    xive->flags = XIVE_SRC_TRIGGER;
> 
> You never actually use this field.  And since it always has the same
> value, is there a point to storing it?

Some HW sources don't have it, so with pass-through maybe...

Cheers,
Ben