[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices |
Date: |
Mon, 4 Dec 2017 10:22:20 +0100 |
On Fri, 1 Dec 2017 15:41:21 +0100
Halil Pasic <address@hidden> wrote:
> On 11/28/2017 04:21 PM, Halil Pasic wrote:
> [..]
> >>> Otherwise at first glance both patches seem sane.
> >>
> >> Can I count this as an ack, or do you plan to do more review?
> >>
> >
> > Yes I was planning to give it another look. And I do already
> > have questions. Isn't the QOM composition tree API? I mean
> > let's assume the QMP commands working on this tree are not completely
> > useless. How is client code (management software) supposed to work,
> > assumed it can rely on paths of e.g. properties being stable. Just
> > imagine we had this default-cssid property (for the sake of the
> > argument, not like we want it) on the css bridge.
>
> Ping! I would like to get this clarified before proceeding with reviewing
> this series.
[It might be helpful to not drop cc:s.]
I don't think we really want a static tree. As long as the devices are
locateable, it should be fine.
>
> >
> > Now if the composition tree is API then these can only be bug fixes
> > (IMHO).
> >
> > There are also other oddities I've spotted. My idea was to put
> > this composition tree discussion on hold until the vfio-ccw stuff
> > is sorted out. I would certainly like to build a better understanding.
> >
> > Halil
> >
>
> [..]
>
>
- Re: [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices, Halil Pasic, 2017/12/01
- Re: [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices,
Cornelia Huck <=
- Re: [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices, Bjoern Walk, 2017/12/05
- Re: [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices, Cornelia Huck, 2017/12/07
- Re: [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices, Halil Pasic, 2017/12/07
- Re: [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices, Cornelia Huck, 2017/12/07
- Re: [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices, Halil Pasic, 2017/12/07
- Re: [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices, Cornelia Huck, 2017/12/08
- Re: [Qemu-devel] [PATCH RFC 0/2] s390x: cut down on unattached devices, Halil Pasic, 2017/12/08