Re: [Qemu-devel] [PULL 0/1] baum braille device update

[Peter Maydell]

On 4 December 2017 at 15:26, Samuel Thibault <address@hidden> wrote:
> Hello,
>
> Peter Maydell, on lun. 04 déc. 2017 15:21:48 +0000, wrote:
>> On 4 December 2017 at 15:17, Samuel Thibault
>> <address@hidden> wrote:
>> > ----------------------------------------------------------------
>> > Samuel Thibault (1):
>> >       baum: Truncate braille device size to 84x1
>>
>> Hi. Is this pull request intended for 2.11?
>
> If possible, yes.
>
>> We're currently in freeze for that and only taking "absolutely release
>> critical" bug fixes...
>
> Ok, as you wish.
>
> It's a relatively corner case: a friend of mine does have a 88-cell
> braille display, and can not use it with guests by running qemu
> -usbdevice braille due to this bug.

Mmm. Looking at the code for baum.c for 2.10, this isn't a
regression from 2.10 or a security issue, which is what it
would need to be for us to want to put this in at this point.

Also, looking in my mail archives I couldn't find where
this patch was initially posted on the list for review. Our
process is that all patches have to be posted for review first,
they can't just go straight into a pull request.

thanks
-- PMM