[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx()
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCHv2 4/5] eepro100: switch e100_compute_mcast_idx() over to use net_crc32() |
|
Date: |
Tue, 5 Dec 2017 08:28:23 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 12/05/2017 02:17 AM, Mark Cave-Ayland wrote:
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> ---
> hw/net/eepro100.c | 19 +------------------
> 1 file changed, 1 insertion(+), 18 deletions(-)
>
> - if (carry) {
> - crc = ((crc ^ POLYNOMIAL) | carry);
How does this compile after 1/5 renames POLYNOMIAL to POLYNOMIAL_BE in
net.h?
/me looks
Oh, you have a redundant definition in the .c file, which is now a dead
define. Patch 1 should be updated to remove the duplicate definitions,
and fix code to uniformly use POLYNOMIAL_BE.
But overall, I like what the series is doing.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature