qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 for-2.12 2/5] s390x/tcg: fix and cleanup mcck


From: David Hildenbrand
Subject: Re: [Qemu-devel] [PATCH v1 for-2.12 2/5] s390x/tcg: fix and cleanup mcck injection
Date: Tue, 5 Dec 2017 17:22:38 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

>> @@ -426,7 +423,8 @@ static void do_mchk_interrupt(CPUS390XState *env)
>>      DPRINTF("%s: %" PRIx64 " %" PRIx64 "\n", __func__,
>>              env->psw.mask, env->psw.addr);
>>  
>> -    load_psw(env, mask, addr);
>> +    load_psw(env, be64_to_cpu(lowcore->mcck_new_psw.mask),
>> +             be64_to_cpu(lowcore->mcck_new_psw.addr));
> 
> ... but here you still touch it? Looks like a bug to me...?

Indeed, didn't notice as the addresses won't change. Thanks!

> 
>  Thomas
> 


-- 

Thanks,

David / dhildenb



reply via email to

[Prev in Thread] Current Thread [Next in Thread]