Re: [Qemu-devel] [PATCH v13 0/6] fsdev: qmp interface for io throttling

[Eric Blake]

On 12/06/2017 10:15 AM, Pradeep Jagadeesh wrote:

>> I didn't have time to follow the thread, but it's been a month without
>> activity... where do we stand now ? I've merged I/O throttle for fsdev
>> in 2.9, is there a chance we get the QMP/HMP part in 2.12 ?
> 
> Hi Greg,
> 
> Yes, I am waiting for Eric's reply. Because there were some issues when
> I merged code with Manos's throttlelimits code. So, I am waiting to see
> how to go about it. It needs some changes to reuse in fsdev/blk qmp
> code. I am very much would like to push qmp code upstream.

We missed the window of opportunity to unify any differences in
interfaces between what Manos added in 2.11 and your code, now that 2.11
is at -rc4.  That means we are stuck with two slightly different
interface; although it would still be nice to have glue code that can
convert into and out of a preferred form, so that the bulk of the code
can be common operations on the preferred struct.

At this point, I don't know what additional information you want from
myself or Markus on the interface front; it may be easier to post a
rebased v14 and tackle it from there (even if it means our interface is
still in a state of churn).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature