[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 12/50] qapi-introspect: add preprocessor cond
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 12/50] qapi-introspect: add preprocessor conditions to generated QLit |
|
Date: |
Thu, 07 Dec 2017 16:41:02 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Add 'ifcond' condition to top-level QLit objects.
>
> to_qlit() handles the (obj, ifcond) tuples in previous patch.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
According to my testing, this patch adds blank lines between the
elements of qmp_schema_qlit. I suspect this is because to_qlit((obj,
None) is not actually equivalent to to_qlit(obj). It should be.
Note that the issue is in PATCH 11, but becomes visible only in PATCH
12, because the new code only gets used in PATCH 12. Consider squashing
the two together.
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 12/50] qapi-introspect: add preprocessor conditions to generated QLit,
Markus Armbruster <=