Re: [Qemu-devel] iSER transport name is not good

[Daniel P. Berrange]

On Fri, Dec 08, 2017 at 03:27:27PM +0800, Charles Kelimod wrote:
> Hi Dave and Sahlberg,
> 
> for this type of name:iser://<host>/<iqn>/<lun>, I completely agree with
> you.
> my issue is when I create an vm from libvirt, the qemu command line should
> be:
> -drive
> file.driver=iser,file.portal=xx.xx.xx.xx:3260,file.target=iqn.xxx,file.lun=0,file.transport=iser
> 
> Actually "iser" is added by me in libvirt, which can work by a little
> modification. But I think file.transport=rdma would be better, as I think
> iser is protocol, and rdma is transport, and libvirt defined it, if I added
> a new transport name (iser) in libvirt, it will be confusable.

If libvirt already supports this, then we won't change it, as that just creates
needless backcompatibility problems. There's many cases where we have wierd or
undesirable names for things, but at a low level we just accept them and carry
on, as wierd names don't have any negative functional impact. At the higher
app user interface, it can be renamed as desired, since UI has no backcompat
problems, as long as the low level stays the same.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|