[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/6] migration: free result string
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/6] migration: free result string |
Date: |
Fri, 8 Dec 2017 10:38:41 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
* Juan Quintela (address@hidden) wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> Reported-by: Peter Xu <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
(same as Marc-André's)
> ---
> tests/migration-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index be598d3257..799e24ebc6 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -358,13 +358,14 @@ static void migrate_check_parameter(QTestState *who,
> const char *parameter,
> const char *value)
> {
> QDict *rsp, *rsp_return;
> - const char *result;
> + char *result;
>
> rsp = wait_command(who, "{ 'execute': 'query-migrate-parameters' }");
> rsp_return = qdict_get_qdict(rsp, "return");
> result = g_strdup_printf("%" PRId64,
> qdict_get_try_int(rsp_return, parameter, -1));
> g_assert_cmpstr(result, ==, value);
> + g_free(result);
> QDECREF(rsp);
> }
>
> --
> 2.14.3
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH v3 2/6] tests: migration test deprecated commands, (continued)
- [Qemu-devel] [PATCH v3 3/6] tests: Add migration precopy test, Juan Quintela, 2017/12/01
- [Qemu-devel] [PATCH v3 6/6] [RFH] tests: Add migration compress threads tests, Juan Quintela, 2017/12/01
- [Qemu-devel] [PATCH v3 1/6] migration: free result string, Juan Quintela, 2017/12/01
- Re: [Qemu-devel] [PATCH v3 1/6] migration: free result string,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH v3 5/6] tests: Add migration xbzrle test, Juan Quintela, 2017/12/01
- Re: [Qemu-devel] [PATCH v3 0/6] Add make check tests for Migration, Eric Blake, 2017/12/01