Re: [Qemu-devel] [PATCH v3 4/4] ivshmem: Disable irqfd on device reset

[Eric Blake]

On 12/08/2017 07:44 AM, Ladi Prosek wrote:

>>>  static void ivshmem_write_config(PCIDevice *pdev, uint32_t address,
>>>                                   uint32_t val, int len)
>>>  {
>>
>> Why are you moving ivshmem_reset()?  Makes the actual change harder to
>> see than necessary.
> 
> ivshmem_disable_irqfd() is declared after ivshmem_reset() in the
> source file. I generally prefer to order static functions
> topologically if possible. If you'd prefer adding a forward decl
> instead (fewer lines touched, easier to bisect?) I can certainly do
> that. Thanks!

That, or split it into two patches (one doing just the code motion, the
other making the semantic change).

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature