[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/12] tests: fix qmp-test leak
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 11/12] tests: fix qmp-test leak |
Date: |
Fri, 08 Dec 2017 19:01:20 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Direct leak of 913 byte(s) in 43 object(s) allocated from:
> #0 0x55880a15df60 in __interceptor_malloc
> (/home/elmarco/src/qq/build/tests/qmp-test+0x110f60)
> #1 0x7f3f20fd098f in _IO_vasprintf (/lib64/libc.so.6+0x8098f)
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
> tests/qmp-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qmp-test.c b/tests/qmp-test.c
> index c5a5c10b41..36feb2204b 100644
> --- a/tests/qmp-test.c
> +++ b/tests/qmp-test.c
> @@ -271,7 +271,7 @@ static void add_query_tests(QmpSchema *schema)
> {
> SchemaInfoList *tail;
> SchemaInfo *si, *arg_type, *ret_type;
> - const char *test_name;
> + char *test_name;
>
> /* Test the query-like commands */
> for (tail = schema->list; tail; tail = tail->next) {
> @@ -297,6 +297,7 @@ static void add_query_tests(QmpSchema *schema)
>
> test_name = g_strdup_printf("qmp/%s", si->name);
> qtest_add_data_func(test_name, si->name, test_query);
> + g_free(test_name);
> }
> }
Reviewed-by: Markus Armbruster <address@hidden>
- [Qemu-devel] [PATCH 05/12] tests: fix check-qobject leak:, (continued)
- [Qemu-devel] [PATCH 05/12] tests: fix check-qobject leak:, Marc-André Lureau, 2017/12/07
- [Qemu-devel] [PATCH 07/12] readline: add a free function, Marc-André Lureau, 2017/12/07
- [Qemu-devel] [PATCH 06/12] vl: fix direct firmware directories leak, Marc-André Lureau, 2017/12/07
- [Qemu-devel] [PATCH 08/12] tests: fix migration-test leak, Marc-André Lureau, 2017/12/07
- [Qemu-devel] [PATCH 09/12] crypto: fix stack-buffer-overflow error, Marc-André Lureau, 2017/12/07
- [Qemu-devel] [PATCH 11/12] tests: fix qmp-test leak, Marc-André Lureau, 2017/12/07
- Re: [Qemu-devel] [PATCH 11/12] tests: fix qmp-test leak,
Markus Armbruster <=
- [Qemu-devel] [PATCH 10/12] qemu-config: fix leak in query-command-line-options, Marc-André Lureau, 2017/12/07
- [Qemu-devel] [PATCH 12/12] WIP ucontext: annotate coroutine stack for ASAN, Marc-André Lureau, 2017/12/07
- Re: [Qemu-devel] [PATCH 00/12] Various build-sys and ASAN related fixes, no-reply, 2017/12/11
- Re: [Qemu-devel] [PATCH 00/12] Various build-sys and ASAN related fixes, no-reply, 2017/12/11
- Re: [Qemu-devel] [PATCH 00/12] Various build-sys and ASAN related fixes, no-reply, 2017/12/11