Re: [Qemu-devel] [PATCH 08/17] iotests: Skip 103 for refcount_bits=1

[Max Reitz]

On 2017-12-09 02:36, John Snow wrote:
> 
> 
> On 11/30/2017 08:23 AM, Max Reitz wrote:
>> On 2017-11-30 04:18, Fam Zheng wrote:
>>> On Thu, 11/23 03:08, Max Reitz wrote:
>>>> Signed-off-by: Max Reitz <address@hidden>
>>>> ---
>>>>  tests/qemu-iotests/103 | 2 ++
>>>>  1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/tests/qemu-iotests/103 b/tests/qemu-iotests/103
>>>> index ecbd8ebd71..d0cfab8844 100755
>>>> --- a/tests/qemu-iotests/103
>>>> +++ b/tests/qemu-iotests/103
>>>> @@ -40,6 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>>>>  _supported_fmt qcow2
>>>>  _supported_proto file nfs
>>>>  _supported_os Linux
>>>> +# Internal snapshots are (currently) impossible with refcount_bits=1
>>>> +_unsupported_imgopts 'refcount_bits=1[^0-9]'
>>>
>>> What is the "[^0-9]" part for?
>>
>> It's so you can specify refcount_bits=16, but not
>> refcount_bits=1,compat=0.10 or just refcount_bits=1.
>>
>> Max
>>
> 
> Worth a comment?

There is a comment above it that says that refcount_bits=1 is the
disallowed option. :-)

I could add a "(refcount_bits=16 is OK, though)" if that would have been
enough for you (or any proposal of yours).

Max

signature.asc
Description: OpenPGP digital signature