[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] hw/arm/virt: Add another UART to the virt b
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] hw/arm/virt: Add another UART to the virt board |
Date: |
Tue, 12 Dec 2017 14:50:50 +0000 |
On 12 December 2017 at 14:45, Andrew Jones <address@hidden> wrote:
> Should this be
>
> if (!vmc->no_second_uart && serial_hds[uart_count] != NULL) {
>
> A bit late now, but maybe the other UART resource allocations should have
> been conditional on actually being wired up too?
What does x86 do?
I think the conclusion we came to about UARTs in general was that
boards should always create the devices, and the UART models
should cope with being passed a NULL chardev backend. (This
is like real hardware, where the 2nd UART always exists even
if you haven't plugged a cable into the 2nd serial port on the
back of the box.)
thanks
-- PMM
[Qemu-devel] [PATCH 2/3] hw/arm/virt: Add another UART to the virt board, Peter Maydell, 2017/12/08
Re: [Qemu-devel] [PATCH 2/3] hw/arm/virt: Add another UART to the virt board, Andrew Jones, 2017/12/12
Re: [Qemu-devel] [PATCH 2/3] hw/arm/virt: Add another UART to the virt board, Andrew Jones, 2017/12/12
Re: [Qemu-devel] [Qemu-arm] [PATCH 0/3] hw/arm/virt: Add another UART, Peter Maydell, 2017/12/08
[Qemu-devel] [PATCH 1/3] hw/arm/virt: Add virt-2.12 machine type, Peter Maydell, 2017/12/08