[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.12 v4 0/3] nvdimm: fixes for (non-)dax bac
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH for-2.12 v4 0/3] nvdimm: fixes for (non-)dax backends |
Date: |
Wed, 13 Dec 2017 11:16:43 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Mon, Dec 11, 2017 at 03:28:03PM +0800, Haozhong Zhang wrote:
> Previous versions can be found at
> v3: https://lists.gnu.org/archive/html/qemu-devel/2017-11/msg04785.html
> v2: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg01203.html
> v1: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg05919.html
>
> Changes in v4:
> * Document new memory-backend-file option 'align' in qemu-options.hx.
> (Eduardo Habkost)
> * Add endian conversion when setting the unarmed flag in NFIT. (Stefan
> Hajnoczi)
>
> Changes in v3:
> * Add an option 'align' to 'memory-backend-file' to address the
> failure when mmap device dax (patch 1).
> * Remove device dax check, which needs to access sysfs and may not
> work with SELinux.
> * Add a boolean option 'unarmed' to '-device nvdimm', which allows
> users to control the unarmed flag in guest ACPI NFIT. I don't make
> it as OnOffAuto, because of the remove of device dax check.
> * Document new options added by this patch series.
>
> Haozhong Zhang (3):
> hostmem-file: add "align" option
> nvdimm: add a macro for property "label-size"
> nvdimm: add 'unarmed' option
>
> backends/hostmem-file.c | 41 ++++++++++++++++++++++++++++++++++++++++-
> docs/nvdimm.txt | 31 +++++++++++++++++++++++++++++++
> exec.c | 8 +++++++-
> hw/acpi/nvdimm.c | 7 +++++++
> hw/mem/nvdimm.c | 28 +++++++++++++++++++++++++++-
> include/exec/memory.h | 3 +++
> include/hw/mem/nvdimm.h | 12 ++++++++++++
> memory.c | 2 ++
> numa.c | 2 +-
> qemu-options.hx | 9 ++++++++-
> 10 files changed, 138 insertions(+), 5 deletions(-)
Looks good to me. I suggest taking this through Eduardo/Igor's host
memory backend tree.
Stefan
signature.asc
Description: PGP signature