[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] block/iscsi: only report an iSCSI Failure i
|
From: |
Peter Lieven |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] block/iscsi: only report an iSCSI Failure if we don't handle it gracefully |
|
Date: |
Wed, 13 Dec 2017 17:28:03 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
Am 08.12.2017 um 18:03 schrieb Eric Blake:
> On 12/08/2017 10:14 AM, Peter Lieven wrote:
>> Am 08.12.2017 um 16:11 schrieb Eric Blake:
>>> On 12/08/2017 05:51 AM, Peter Lieven wrote:
>>>> we currently report an "iSCSI Failure" in iscsi_co_generic_cb if the task
>>>> hasn't completed with SCSI_STATUS_GOOD. However, we expect a failure in
>>>> some cases and handle it gracefully. This is the case for misaligned UNMAPs
>>> Is the block layer still capable of producing a misaligned UNMAP? If
>>> so, that's probably a bug in the block layer for not honoring the block
>>> limit geometries.
>> In theory there should be none. I think we can drop this code.
> Or, better yet, replace the check with an assert.
I would not add an assert if the device returns a CHECK CONDITION because
there might be other reasons for it. But I think its safe to remove the extra
handling.
If for any reason there is a request that the target does not like it will pop
up on
stderr.
Peter