[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/6] block: avoid recursive AioContext acquir
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/6] block: avoid recursive AioContext acquire in bdrv_inactivate_all() |
Date: |
Wed, 13 Dec 2017 22:23:02 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 07/12/2017 21:13, Stefan Hajnoczi wrote:
> v2:
> * Added docs/devel/multiple-iothreads.txt doc update [Kevin]
> * Added qemu-iotests 203 test case [Kevin]
> * Added iothread_stop() race fix to make 203 reliable
>
> Patch 1 is Paolo's recursive locking removal in bdrv_inactivate_all(). This
> solve migration hangs and is the main point of the patch series.
>
> Patches 2-6 add a qemu-iotests test case and update the multiple-iothreads.txt
> documentation to discourage recursive AioContext locking.
>
> Based-on: <address@hidden>
>
> Paolo Bonzini (1):
> block: avoid recursive AioContext acquire in bdrv_inactivate_all()
>
> Stefan Hajnoczi (5):
> docs: mark nested AioContext locking as a legacy API
> blockdev: add x-blockdev-set-iothread force boolean
> iotests: add VM.add_object()
> iothread: fix iothread_stop() race condition
> qemu-iotests: add 203 savevm with IOThreads test
>
> docs/devel/multiple-iothreads.txt | 7 +++--
> qapi/block-core.json | 6 +++-
> include/sysemu/iothread.h | 3 +-
> block.c | 14 ++++++++--
> blockdev.c | 11 ++++----
> iothread.c | 20 +++++++++----
> tests/qemu-iotests/203 | 59
> +++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/203.out | 6 ++++
> tests/qemu-iotests/group | 1 +
> tests/qemu-iotests/iotests.py | 5 ++++
> 10 files changed, 114 insertions(+), 18 deletions(-)
> create mode 100755 tests/qemu-iotests/203
> create mode 100644 tests/qemu-iotests/203.out
>
Reviewed-by: Paolo Bonzini <address@hidden>
aio_notify should also be put on the blacklist of things that have
slowly become bad ideas. :|
Paolo
- [Qemu-devel] [PATCH v2 2/6] docs: mark nested AioContext locking as a legacy API, (continued)
- [Qemu-devel] [PATCH v2 2/6] docs: mark nested AioContext locking as a legacy API, Stefan Hajnoczi, 2017/12/07
- [Qemu-devel] [PATCH v2 3/6] blockdev: add x-blockdev-set-iothread force boolean, Stefan Hajnoczi, 2017/12/07
- [Qemu-devel] [PATCH v2 4/6] iotests: add VM.add_object(), Stefan Hajnoczi, 2017/12/07
- [Qemu-devel] [PATCH v2 5/6] iothread: fix iothread_stop() race condition, Stefan Hajnoczi, 2017/12/07
- [Qemu-devel] [PATCH v2 6/6] qemu-iotests: add 203 savevm with IOThreads test, Stefan Hajnoczi, 2017/12/07
- Re: [Qemu-devel] [PATCH v2 0/6] block: avoid recursive AioContext acquire in bdrv_inactivate_all(),
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v2 0/6] block: avoid recursive AioContext acquire in bdrv_inactivate_all(), Stefan Hajnoczi, 2017/12/14