[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/13] i.MX FEC and SD changes
From: |
Andrey Smirnov |
Subject: |
Re: [Qemu-devel] [PATCH 00/13] i.MX FEC and SD changes |
Date: |
Thu, 14 Dec 2017 06:09:25 -0800 |
On Tue, Dec 12, 2017 at 9:40 AM, Peter Maydell <address@hidden> wrote:
> On 11 December 2017 at 21:29, Andrey Smirnov <address@hidden> wrote:
>> Hi everyone,
>>
>> This patchset is a spin-off from original i.MX7 support submission
>> found here [1], containing all of the patchest that are more or less
>> agreed upon and are ready (hopefully!) for inclusion.
>>
>> Changes since [1]:
>>
>> - Rx buffer in FEC was moved from stack to heap to allow
>> worry-free expansion to 16K limit.
>>
>> - Added more comments explaining rather convoluted bit-moving
>> in eSHDC emuation code
>>
>> - Triple Tx ring DMA "VMState" code was changed to follow
>> Peter's recommendations (avoiding the need to incrememnt the
>> version_id)
>>
>> - FSL_IMX25_FEC_SIZE is used as a size of FEC's register file
>>
>> - Removed leftover code from "imx_fec: Change queue flushing
>> heuristics"
>>
>> [1] https://lists.gnu.org/archive/html/qemu-arm/2017-11/msg00045.html
>
> Hi; thanks for sending this set separately. Patch 4 ("Move Tx frame buffer
> away from the stack") seems to have got lost -- it isn't in the mailing
> list archives or my mailbox. Could you try resending that one?
>
My bad, I forgot to add correct Cc tags to that one. I am a bit
surprised it's not in the archive since it did have correct To: info,
but it doesn't matter. I'll make sure this patch is sent out in v2.
> Incidentally we should use the new i.MX SDHCI controller in the
> imx6: coincidentally somebody ran into this bug recently:
> https://stackoverflow.com/questions/47538951/qemu-freescale-i-mx6-duallite-sabre-root-filesystem-does-not-mount/47552596
>
> I'll retest that this patchset works with my imx6 image, and
> send a patch to sit on top of it to switch imx6 over to TYPE_IMX_USDHC.
>
Out of curiosity, I gave emulating SD on i.MX6 a try and it mostly
worked (there were other unrelated to SD problems). I'll include what
I came up with and we can go from there.
Thanks,
Andrey Smirnov
- [Qemu-devel] [PATCH 11/13] imx_fec: Reserve full FSL_IMX25_FEC_SIZE page for the register file, (continued)
- [Qemu-devel] [PATCH 11/13] imx_fec: Reserve full FSL_IMX25_FEC_SIZE page for the register file, Andrey Smirnov, 2017/12/11
- [Qemu-devel] [PATCH 08/13] imx_fec: Add support for multiple Tx DMA rings, Andrey Smirnov, 2017/12/11
- [Qemu-devel] [PATCH 12/13] sdhci: Add i.MX specific subtype of SDHCI, Andrey Smirnov, 2017/12/11
- [Qemu-devel] [PATCH 13/13] sdhci: Implement write method of ACMD12ERRSTS register, Andrey Smirnov, 2017/12/11
- Re: [Qemu-devel] [PATCH 00/13] i.MX FEC and SD changes, Peter Maydell, 2017/12/12