[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 20/46] s390x/tcg: drop program_interrupt()
From: |
Cornelia Huck |
Subject: |
[Qemu-devel] [PULL 20/46] s390x/tcg: drop program_interrupt() |
Date: |
Thu, 14 Dec 2017 18:09:38 +0100 |
From: David Hildenbrand <address@hidden>
All users are gone, we can finally drop it and make sure that all new
program interrupt injections are reminded of the retaddr - as they have to
use s390_program_interrupt() now.
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
---
target/s390x/cpu.h | 1 -
target/s390x/interrupt.c | 22 +++++-----------------
2 files changed, 5 insertions(+), 18 deletions(-)
diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
index ae61d18c0a..9cfbbbac04 100644
--- a/target/s390x/cpu.h
+++ b/target/s390x/cpu.h
@@ -719,7 +719,6 @@ void s390_io_interrupt(uint16_t subchannel_id, uint16_t
subchannel_nr,
uint32_t io_int_parm, uint32_t io_int_word);
/* automatically detect the instruction length */
#define ILEN_AUTO 0xff
-void program_interrupt(CPUS390XState *env, uint32_t code, int ilen);
#define RA_IGNORED 0
void s390_program_interrupt(CPUS390XState *env, uint32_t code, int ilen,
uintptr_t ra);
diff --git a/target/s390x/interrupt.c b/target/s390x/interrupt.c
index b07e75daed..39c026b8b5 100644
--- a/target/s390x/interrupt.c
+++ b/target/s390x/interrupt.c
@@ -27,17 +27,18 @@ void trigger_pgm_exception(CPUS390XState *env, uint32_t
code, uint32_t ilen)
}
static void tcg_s390_program_interrupt(CPUS390XState *env, uint32_t code,
- int ilen)
+ int ilen, uintptr_t ra)
{
#ifdef CONFIG_TCG
trigger_pgm_exception(env, code, ilen);
- cpu_loop_exit(CPU(s390_env_get_cpu(env)));
+ cpu_loop_exit_restore(CPU(s390_env_get_cpu(env)), ra);
#else
g_assert_not_reached();
#endif
}
-void program_interrupt(CPUS390XState *env, uint32_t code, int ilen)
+void s390_program_interrupt(CPUS390XState *env, uint32_t code, int ilen,
+ uintptr_t ra)
{
S390CPU *cpu = s390_env_get_cpu(env);
@@ -47,25 +48,12 @@ void program_interrupt(CPUS390XState *env, uint32_t code,
int ilen)
if (kvm_enabled()) {
kvm_s390_program_interrupt(cpu, code);
} else if (tcg_enabled()) {
- tcg_s390_program_interrupt(env, code, ilen);
+ tcg_s390_program_interrupt(env, code, ilen, ra);
} else {
g_assert_not_reached();
}
}
-void s390_program_interrupt(CPUS390XState *env, uint32_t code, int ilen,
- uintptr_t ra)
-{
-#ifdef CONFIG_TCG
- S390CPU *cpu = s390_env_get_cpu(env);
-
- if (tcg_enabled()) {
- cpu_restore_state(CPU(cpu), ra);
- }
-#endif
- program_interrupt(env, code, ilen);
-}
-
#if !defined(CONFIG_USER_ONLY)
static void cpu_inject_service(S390CPU *cpu, uint32_t param)
{
--
2.13.6
- [Qemu-devel] [PULL 09/46] s390x/ioinst: pass the retaddr to all IO instructions, (continued)
- [Qemu-devel] [PULL 09/46] s390x/ioinst: pass the retaddr to all IO instructions, Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 11/46] s390x/diag: pass the retaddr into handle_diag_308(), Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 12/46] s390x: handle exceptions during s390_cpu_virt_mem_rw() correctly (TCG), Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 14/46] s390x/tcg: io instructions don't need potential_page_fault(), Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 13/46] s390x/tcg: don't exit the cpu loop in s390_cpu_virt_mem_rw(), Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 15/46] s390x/tcg: use s390_program_interrupt() in SCLP Service Call, Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 16/46] s390x/tcg: use s390_program_interrupt() in DIAG, Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 17/46] s390x/tcg: use s390_program_interrupt() in per_check_exception(), Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 18/46] s390x/tcg: use s390_program_interrupt() in SACF, Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 19/46] s390x/tcg: use s390_program_interrupt() in STSI, Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 20/46] s390x/tcg: drop program_interrupt(),
Cornelia Huck <=
- [Qemu-devel] [PULL 21/46] s390x/tcg: drop potential_page_fault(), Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 22/46] s390x/pci: factor out endianess conversion, Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 23/46] s390x/pci: rework PCI STORE, Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 24/46] s390x/pci: rework PCI LOAD, Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 25/46] s390x/pci: rework PCI STORE BLOCK, Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 26/46] s390x/pci: move the memory region read from pcilg, Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 27/46] s390x/pci: move the memory region write from pcistg, Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 28/46] s390x/pci: search for subregion inside the BARs, Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 29/46] s390x/css: unrestrict cssids, Cornelia Huck, 2017/12/14
- [Qemu-devel] [PULL 30/46] s390x: deprecate s390-squash-mcss machine prop, Cornelia Huck, 2017/12/14