[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/14] sdhci: add a trace event for the LED cont
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH 12/14] sdhci: add a trace event for the LED control |
|
Date: |
Thu, 14 Dec 2017 20:32:32 -0300 |
On Thu, Dec 14, 2017 at 2:55 PM, Alistair Francis
<address@hidden> wrote:
> On Wed, Dec 13, 2017 at 11:58 AM, Philippe Mathieu-Daudé
> <address@hidden> wrote:
>> It blinks to caution the user not to remove the card while the SD card is
>> being accessed.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>
> If you turn this on does it just fill the trace log?
>
> It seems like this will generate too much output if it happens on
> every LED blink.
You don't need to enable this trace event if you don't want it :)
It is supposed to turn ON previous to start write access, and then turn OFF.
Anyway you are right, I currently log it on each access while I should
just log the ON/OFF state changes, I'll fix this.
- Re: [Qemu-devel] [PATCH 10/14] sdhci: use qemu_log_mask(UNIMP) instead of fprintf(), (continued)
[Qemu-devel] [PATCH 09/14] sdhci: refactor common sysbus/pci unrealize() into sdhci_unrealizefn(), Philippe Mathieu-Daudé, 2017/12/13
[Qemu-devel] [PATCH 11/14] sdhci: convert the DPRINT() calls into trace events, Philippe Mathieu-Daudé, 2017/12/13
[Qemu-devel] [PATCH 12/14] sdhci: add a trace event for the LED control, Philippe Mathieu-Daudé, 2017/12/13
[Qemu-devel] [PATCH 13/14] sdhci: add sdhci_init_capareg() to initialize the CAPAB register, Philippe Mathieu-Daudé, 2017/12/13
[Qemu-devel] [PATCH 14/14] sdhci: add a "dma-memory" property, Philippe Mathieu-Daudé, 2017/12/13