Re: [Qemu-devel] [PATCH v4 00/46] Windbg supporting

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v4 00/46] Windbg supporting
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
58431d9904 windbg: maintainers
78d99f7ae4 windbg: changed kd_api_read_msr and kd_api_write_msr
5bb0a7003a windbg: implemented kd_api_get_context_ex and kd_api_set_context_ex
8fc326043e windbg: added new api functions
6650a95149 windbg: implemented kd_api_query_memory
8400b68dcf windbg: implemented kd_api_fill_memory
f25d62262c windbg: implemented kd_api_search_memory
ebf7cf6793 windbg: implemented kd_api_read_msr and kd_api_write_msr
8a4251ff1e windbg: implemented kd_api_get_version
f734205596 windbg: implemented kd_api_read_physical_memory and 
kd_api_write_physical_memory
1d12684df3 windbg: implemented kd_api_read_io_space and kd_api_write_io_space
b5a6e5fedb windbg: implemented kd_api_continue
57cf072d26 windbg: debug exception subscribing
057b65fc51 windbg: implemented kd_api_write_breakpoint and 
kd_api_restore_breakpoint
a87d866f8d windbg: implemented windbg_hw_breakpoint_insert and 
windbg_hw_breakpoint_remove
70c504d228 windbg: implemented windbg_set_dr7
f64b0e9fc3 windbg: implemented windbg_set_dr
716d542ebf windbg: implemented windbg_set_sr
834eac7ea6 windbg: implemented windbg_write_ks_regs
df2c3ebf03 windbg: implemented windbg_read_ks_regs
9a52503388 windbg: implemented windbg_write_context
452efa0df4 windbg: implemented windbg_read_context
01e4c9c8f7 windbg: implemented kd_api_read_control_space and 
kd_api_write_control_space
7c6d21f00b windbg: implemented kd_api_get_context and kd_api_set_context
7c4db9ba7a windbg: kernel's structures
6f53a8602f windbg: implemented kd_api_read_virtual_memory and 
kd_api_write_virtual_memory
d454b3d90d windbg: implemented windbg_process_manipulate_packet
afa99fd57f windbg: implemented windbg_process_data_packet
6b9a5a1ca5 windbg: implemented windbg_process_control_packet
01ebabc67c windbg: windbg_vm_stop
d0aaa1e9e9 windbg: generate LoadSymbolsStateChange
7e577c9403 windbg: generate ExceptionStateChange
f812f46fd9 windbg: init DBGKD_ANY_WAIT_STATE_CHANGE
4d45914934 windbg: handler of parsing context
3a0baa7d94 windbg: send data and control packets
0c50e60a02 windbg: parsing data stream
29a8ab9969 windbg: structures for parsing data stream
3c4d7f186e windbg: handler of fs/gs register
0d003c70c0 windbg: hook to wrmsr operation
068c8079dc windbg: added chardev
982d699aea windbg: added WindbgState
1a48b5ec91 windbg: added helper features
61dbec6ff4 windbg: added '-windbg' option
a3c38220a7 windbg: modified windbgkd.h
4b5072a568 windbg: added windbg's KD header file
e212fbab34 windbg: added empty windbgstub files

=== OUTPUT BEGIN ===
Checking PATCH 1/46: windbg: added empty windbgstub files...
ERROR: do not set execute permissions for source files
#28: FILE: include/exec/windbgstub-utils.h

ERROR: do not set execute permissions for source files
#52: FILE: include/exec/windbgstub.h

ERROR: do not set execute permissions for source files
#87: FILE: stubs/windbgstub.c

ERROR: do not set execute permissions for source files
#121: FILE: target/i386/windbgstub.c

ERROR: do not set execute permissions for source files
#139: FILE: windbgstub-utils.c

ERROR: do not set execute permissions for source files
#157: FILE: windbgstub.c

total: 6 errors, 0 warnings, 119 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/46: windbg: added windbg's KD header file...
ERROR: do not set execute permissions for source files
#14: FILE: include/exec/windbgkd.h

total: 1 errors, 0 warnings, 879 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/46: windbg: modified windbgkd.h...
Checking PATCH 4/46: windbg: added '-windbg' option...
Checking PATCH 5/46: windbg: added helper features...
Checking PATCH 6/46: windbg: added WindbgState...
Checking PATCH 7/46: windbg: added chardev...
Checking PATCH 8/46: windbg: hook to wrmsr operation...
Checking PATCH 9/46: windbg: handler of fs/gs register...
Checking PATCH 10/46: windbg: structures for parsing data stream...
Checking PATCH 11/46: windbg: parsing data stream...
Checking PATCH 12/46: windbg: send data and control packets...
Checking PATCH 13/46: windbg: handler of parsing context...
Checking PATCH 14/46: windbg: init DBGKD_ANY_WAIT_STATE_CHANGE...
Checking PATCH 15/46: windbg: generate ExceptionStateChange...
Checking PATCH 16/46: windbg: generate LoadSymbolsStateChange...
Checking PATCH 17/46: windbg: windbg_vm_stop...
Checking PATCH 18/46: windbg: implemented windbg_process_control_packet...
Checking PATCH 19/46: windbg: implemented windbg_process_data_packet...
Checking PATCH 20/46: windbg: implemented windbg_process_manipulate_packet...
Checking PATCH 21/46: windbg: implemented kd_api_read_virtual_memory and 
kd_api_write_virtual_memory...
Checking PATCH 22/46: windbg: kernel's structures...
Checking PATCH 23/46: windbg: implemented kd_api_get_context and 
kd_api_set_context...
Checking PATCH 24/46: windbg: implemented kd_api_read_control_space and 
kd_api_write_control_space...
Checking PATCH 25/46: windbg: implemented windbg_read_context...
Checking PATCH 26/46: windbg: implemented windbg_write_context...
Checking PATCH 27/46: windbg: implemented windbg_read_ks_regs...
Checking PATCH 28/46: windbg: implemented windbg_write_ks_regs...
Checking PATCH 29/46: windbg: implemented windbg_set_sr...
Checking PATCH 30/46: windbg: implemented windbg_set_dr...
Checking PATCH 31/46: windbg: implemented windbg_set_dr7...
Checking PATCH 32/46: windbg: implemented windbg_hw_breakpoint_insert and 
windbg_hw_breakpoint_remove...
Checking PATCH 33/46: windbg: implemented kd_api_write_breakpoint and 
kd_api_restore_breakpoint...
Checking PATCH 34/46: windbg: debug exception subscribing...
Checking PATCH 35/46: windbg: implemented kd_api_continue...
Checking PATCH 36/46: windbg: implemented kd_api_read_io_space and 
kd_api_write_io_space...
Checking PATCH 37/46: windbg: implemented kd_api_read_physical_memory and 
kd_api_write_physical_memory...
Checking PATCH 38/46: windbg: implemented kd_api_get_version...
Checking PATCH 39/46: windbg: implemented kd_api_read_msr and 
kd_api_write_msr...
Checking PATCH 40/46: windbg: implemented kd_api_search_memory...
Checking PATCH 41/46: windbg: implemented kd_api_fill_memory...
Checking PATCH 42/46: windbg: implemented kd_api_query_memory...
Checking PATCH 43/46: windbg: added new api functions...
Checking PATCH 44/46: windbg: implemented kd_api_get_context_ex and 
kd_api_set_context_ex...
Checking PATCH 45/46: windbg: changed kd_api_read_msr and kd_api_write_msr...
Checking PATCH 46/46: windbg: maintainers...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden