Re: [Qemu-devel] [qemu-s390x] [PULL 00/46] First batch of s390x patches for 2.12

[David Hildenbrand]

On 15.12.2017 10:53, Christian Borntraeger wrote:
> 
> 
> On 12/15/2017 10:53 AM, David Hildenbrand wrote:
>>
>>> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
>>> index 80e753a5ef..9abb8de9f9 100644
>>> --- a/hw/s390x/s390-virtio-ccw.c
>>> +++ b/hw/s390x/s390-virtio-ccw.c
>>> @@ -172,9 +172,10 @@ static void s390_memory_init(ram_addr_t mem_size)
>>>      name = g_strdup_printf("s390.ram");
>>>      while (mem_size) {
>>>          MemoryRegion *ram = g_new(MemoryRegion, 1);
>>> +       unsigned long long size = mem_size;
>>>  
>>>          /* KVM does not allow memslots >= 8 TB */
>>> -        chunk = MIN(mem_size, KVM_SLOT_MAX_BYTES);
>>> +        chunk = MIN(size, KVM_SLOT_MAX_BYTES);
>>
>> directly cast inline?
> As I said, this still triggers the warning. gcc 7 is too clever.

Whoops missed that.


-- 

Thanks,

David / dhildenb