[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 11/13] tests: fix qmp-test leak
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 11/13] tests: fix qmp-test leak |
Date: |
Fri, 15 Dec 2017 15:11:32 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 12/15/2017 12:06 PM, Marc-André Lureau wrote:
> Direct leak of 913 byte(s) in 43 object(s) allocated from:
> #0 0x55880a15df60 in __interceptor_malloc
> (/home/elmarco/src/qq/build/tests/qmp-test+0x110f60)
> #1 0x7f3f20fd098f in _IO_vasprintf (/lib64/libc.so.6+0x8098f)
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/qmp-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qmp-test.c b/tests/qmp-test.c
> index c5a5c10b41..36feb2204b 100644
> --- a/tests/qmp-test.c
> +++ b/tests/qmp-test.c
> @@ -271,7 +271,7 @@ static void add_query_tests(QmpSchema *schema)
> {
> SchemaInfoList *tail;
> SchemaInfo *si, *arg_type, *ret_type;
> - const char *test_name;
> + char *test_name;
>
> /* Test the query-like commands */
> for (tail = schema->list; tail; tail = tail->next) {
> @@ -297,6 +297,7 @@ static void add_query_tests(QmpSchema *schema)
>
> test_name = g_strdup_printf("qmp/%s", si->name);
> qtest_add_data_func(test_name, si->name, test_query);
> + g_free(test_name);
> }
> }
>
>
- [Qemu-devel] [PATCH v2 06/13] vl: fix direct firmware directories leak, (continued)
- [Qemu-devel] [PATCH v2 06/13] vl: fix direct firmware directories leak, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 05/13] tests: fix check-qobject leak:, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 09/13] crypto: fix stack-buffer-overflow error, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 07/13] readline: add a free function, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 08/13] tests: fix migration-test leak, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 11/13] tests: fix qmp-test leak, Marc-André Lureau, 2017/12/15
- Re: [Qemu-devel] [PATCH v2 11/13] tests: fix qmp-test leak,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v2 10/13] qemu-config: fix leak in query-command-line-options, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 12/13] ucontext: annotate coroutine stack for ASAN, Marc-André Lureau, 2017/12/15
- [Qemu-devel] [PATCH v2 13/13] tests: fix coroutine leak in /basic/entered, Marc-André Lureau, 2017/12/15
- Re: [Qemu-devel] [PATCH v2 00/13] Various build-sys and ASAN related fixes, Marc-André Lureau, 2017/12/15