[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations |
Date: |
Fri, 15 Dec 2017 20:26:22 +0200 |
On Sat, Dec 16, 2017 at 01:21:52AM +0900, Tetsuo Handa wrote:
> My understanding is that virtio-balloon wants to handle sparsely spreaded
> unsigned long values (which is PATCH 4/7) and wants to find all chunks of
> consecutive "1" bits efficiently. Therefore, I guess that holding the values
> in ascending order at store time is faster than sorting the values at read
> time.
Are you asking why is a bitmap used here, as opposed to a tree? It's
not just store versus read. There's also the issue that memory can get
highly fragmented, if it is, the number of 1s is potentially very high.
A bitmap can use as little as 1 bit per value, it is hard to beat in
this respect.
--
MST
- Re: [Qemu-devel] [PATCH v19 2/7] xbitmap: potential improvement, (continued)
- [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Wei Wang, 2017/12/12
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Tetsuo Handa, 2017/12/12
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Wei Wang, 2017/12/13
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Tetsuo Handa, 2017/12/13
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Wei Wang, 2017/12/13
- Re: [Qemu-devel] [virtio-dev] Re: [PATCH v19 3/7] xbitmap: add more operations, Wei Wang, 2017/12/14
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Tetsuo Handa, 2017/12/14
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Matthew Wilcox, 2017/12/14
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Tetsuo Handa, 2017/12/15
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Tetsuo Handa, 2017/12/15
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Matthew Wilcox, 2017/12/16
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Tetsuo Handa, 2017/12/16
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Matthew Wilcox, 2017/12/15
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Matthew Wilcox, 2017/12/15
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Wang, Wei W, 2017/12/17
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Matthew Wilcox, 2017/12/17
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Wei Wang, 2017/12/17
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Matthew Wilcox, 2017/12/17
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Wei Wang, 2017/12/16