[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations
From: |
Matthew Wilcox |
Subject: |
Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations |
Date: |
Fri, 15 Dec 2017 10:42:56 -0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Tue, Dec 12, 2017 at 07:55:55PM +0800, Wei Wang wrote:
> +int xb_preload_and_set_bit(struct xb *xb, unsigned long bit, gfp_t gfp);
I'm struggling to understand when one would use this. The xb_ API
requires you to handle your own locking. But specifying GFP flags
here implies you can sleep. So ... um ... there's no locking?
> +void xb_clear_bit_range(struct xb *xb, unsigned long start, unsigned long
> end);
That's xb_zero() which you deleted with the previous patch ... remember,
keep things as close as possible to the bitmap API.
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, (continued)
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Matthew Wilcox, 2017/12/15
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Matthew Wilcox, 2017/12/15
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Wang, Wei W, 2017/12/17
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Matthew Wilcox, 2017/12/17
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Wei Wang, 2017/12/17
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Matthew Wilcox, 2017/12/17
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Wei Wang, 2017/12/16
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Matthew Wilcox, 2017/12/14
Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations,
Matthew Wilcox <=
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Wei Wang, 2017/12/16
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Tetsuo Handa, 2017/12/16
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Wei Wang, 2017/12/17
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Tetsuo Handa, 2017/12/17
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Wang, Wei W, 2017/12/17
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Tetsuo Handa, 2017/12/17
- Re: [Qemu-devel] [PATCH v19 3/7] xbitmap: add more operations, Wei Wang, 2017/12/18
[Qemu-devel] [PATCH v19 4/7] virtio-balloon: VIRTIO_BALLOON_F_SG, Wei Wang, 2017/12/12
[Qemu-devel] [PATCH v19 5/7] mm: support reporting free page blocks, Wei Wang, 2017/12/12
[Qemu-devel] [PATCH v19 6/7] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ, Wei Wang, 2017/12/12