Re: [Qemu-devel] [PATCH 0/2] scsi: Simple ALUA support

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/2] scsi: Simple ALUA support
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
01f624a08c scsi: Implement multipath support
a57f951050 block: implement shared block device count

=== OUTPUT BEGIN ===
Checking PATCH 1/2: block: implement shared block device count...
ERROR: braces {} are necessary for all arms of this statement
#27: FILE: block.c:3810:
+    if (!bs->filename)
[...]

ERROR: braces {} are necessary for all arms of this statement
#30: FILE: block.c:3813:
+        if (tmp_bs == bs)
[...]

total: 2 errors, 0 warnings, 76 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/2: scsi: Implement multipath support...
ERROR: braces {} are necessary for all arms of this statement
#25: FILE: block.c:3844:
+    if (!bs->filename || !shared_mask)
[...]

ERROR: do not use C99 // comments
#48: FILE: hw/scsi/scsi-disk.c:680:
+                outbuf[buflen++] = 0x61; // SAS / Binary

WARNING: line over 80 characters
#49: FILE: hw/scsi/scsi-disk.c:681:
+                outbuf[buflen++] = 0x95; // PIV / Target port / target port 
group

ERROR: do not use C99 // comments
#49: FILE: hw/scsi/scsi-disk.c:681:
+                outbuf[buflen++] = 0x95; // PIV / Target port / target port 
group

ERROR: do not use C99 // comments
#50: FILE: hw/scsi/scsi-disk.c:682:
+                outbuf[buflen++] = 0; // reserved

ERROR: braces {} are necessary for all arms of this statement
#96: FILE: hw/scsi/scsi-disk.c:1907:
+        if (!test_bit(i, &shared_mask))
[...]

total: 5 errors, 1 warnings, 129 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden