[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scsi: replace hex constants with #defines
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH] scsi: replace hex constants with #defines |
Date: |
Sun, 17 Dec 2017 12:11:17 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 12/17/2017 02:29 AM, Paolo Bonzini wrote:
> Sense keys have nice #defines in scsi/constants.h, use them.
>
> Reported-by: Dr. David Alan Gilbert <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> scsi/utils.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/scsi/utils.c b/scsi/utils.c
> index 61bc1a8e2b..ddae650a99 100644
> --- a/scsi/utils.c
> +++ b/scsi/utils.c
> @@ -339,16 +339,16 @@ int scsi_convert_sense(uint8_t *in_buf, int in_len,
> int scsi_sense_to_errno(int key, int asc, int ascq)
> {
> switch (key) {
> - case 0x00: /* NO SENSE */
> - case 0x01: /* RECOVERED ERROR */
> - case 0x06: /* UNIT ATTENTION */
> + case NO_SENSE:
> + case RECOVERED_ERROR:
> + case UNIT_ATTENTION:
> /* These sense keys are not errors */
> return 0;
> - case 0x0b: /* COMMAND ABORTED */
> + case ABORTED_COMMAND: /* COMMAND ABORTED */
> return ECANCELED;
> - case 0x02: /* NOT READY */
> - case 0x05: /* ILLEGAL REQUEST */
> - case 0x07: /* DATA PROTECTION */
> + case NOT_READY:
> + case ILLEGAL_REQUEST:
> + case DATA_PROTECT:
> /* Parse ASCQ */
> break;
> default:
>