[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tpm: add stubs for qdev-prop-tpm
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH] tpm: add stubs for qdev-prop-tpm |
|
Date: |
Mon, 18 Dec 2017 12:58:38 -0300 |
>> Add some proper stubs for those functions.
>>
>> Fixes: 493b78303532 ("qdev: add DEFINE_PROP_TPMBE")
>> Reported-by: Thomas Huth <address@hidden>
>> Signed-off-by: Cornelia Huck <address@hidden>
>
> Maybe all the new code can be moved from qdev-properties-system.c to
> hw/tpm/qdev.c instead? (Adding stubs should be the last resort,
> especially if the stubs are never used outside system emulation).
This is worth an entry in HACKING :)