[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/7] tcg: Allow 6 arguments to TCG helpers
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 7/7] tcg: Allow 6 arguments to TCG helpers |
|
Date: |
Mon, 18 Dec 2017 11:20:25 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 |
On 12/15/2017 10:06 AM, Philippe Mathieu-Daudé wrote:
>> @@ -305,14 +305,16 @@ static const int tcg_target_call_iarg_regs[] = {
>> TCG_REG_R4,
>> #endif
>> TCG_REG_R5,
>> + TCG_REG_R6,
>> #if TCG_TARGET_REG_BITS == 32
>> /* 32 bit hosts need 2 * MAX_OPC_PARAM_IARGS registers. */
>> - TCG_REG_R6,
>> TCG_REG_R7,
>
> I think now TCG_REG_R8 belongs here...
>
>> #if TCG_TARGET_NB_REGS >= 16
>> TCG_REG_R8,
>
> ^ not here.
Why? Unless TCG_TARGET_NB_REGS >= 16, TCG_REG_R8 doesn't exist.
I'd say this over-configuration of TCI ought to be cleaned up,
but I'd rather remove it entirely.
r~
- Re: [Qemu-devel] [PATCH 2/7] target/moxie: Fix tlb_fill, (continued)
- [Qemu-devel] [PATCH 1/7] target/*helper: don't check retaddr before calling cpu_restore_state, Richard Henderson, 2017/12/15
- [Qemu-devel] [PATCH 3/7] tcg: Remove TCGV_UNUSED* and TCGV_IS_UNUSED*, Richard Henderson, 2017/12/15
- [Qemu-devel] [PATCH 5/7] tcg: Generalize TCGOp parameters, Richard Henderson, 2017/12/15
- [Qemu-devel] [PATCH 4/7] tcg: Dynamically allocate TCGOps, Richard Henderson, 2017/12/15
- [Qemu-devel] [PATCH 6/7] tcg: Add tcg_signed_cond, Richard Henderson, 2017/12/15
- [Qemu-devel] [PATCH 7/7] tcg: Allow 6 arguments to TCG helpers, Richard Henderson, 2017/12/15
- Re: [Qemu-devel] [PATCH 0/7] TCG misc patches, no-reply, 2017/12/15