Re: [Qemu-devel] [PATCH] s390x/sclp: fixup highest CPU address

[David Hildenbrand]

On 19.12.2017 09:28, Christian Borntraeger wrote:
> the highest cpu address is not the same as max_cpus. max_cpus
> counts from 1 while the cpu address starts at 0.
> 
> Signed-off-by: Christian Borntraeger <address@hidden>
> Reviewed-by: Jason J. Herne <address@hidden>
> ---
>  hw/s390x/sclp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c
> index 9be0cb80ad..21351ffffc 100644
> --- a/hw/s390x/sclp.c
> +++ b/hw/s390x/sclp.c
> @@ -67,7 +67,7 @@ static void read_SCP_info(SCLPDevice *sclp, SCCB *sccb)
>      prepare_cpu_entries(sclp, read_info->entries, &cpu_count);
>      read_info->entries_cpu = cpu_to_be16(cpu_count);
>      read_info->offset_cpu = cpu_to_be16(offsetof(ReadInfo, entries));
> -    read_info->highest_cpu = cpu_to_be16(max_cpus);
> +    read_info->highest_cpu = cpu_to_be16(max_cpus - 1);
>  
>      read_info->ibc_val = cpu_to_be32(s390_get_ibc_val());
>  
> 

Reviewed-by: David Hildenbrand <address@hidden>

-- 

Thanks,

David / dhildenb