[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement
From: |
Matthew Wilcox |
Subject: |
Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement |
Date: |
Tue, 19 Dec 2017 06:40:20 -0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Tue, Dec 19, 2017 at 11:05:11PM +0900, Tetsuo Handa wrote:
> Removing exceptional path made this patch easier to read.
> But what I meant is
>
> Can you eliminate exception path and fold all xbitmap patches into one, and
> post only one xbitmap patch without virtio-balloon changes?
>
> .
>
> I still think we don't need xb_preload()/xb_preload_end().
> I think xb_find_set() has a bug in !node path.
Don't think. Write a test-case. Please. If it shows a bug, then great,
Wei has an example of what the bug is to fix. If it doesn't show a bug,
then we can add it to the test suite anyway, to ensure that case continues
to work in the future.
> Also, please avoid unconditionally adding to builtin modules.
> There are users who want to save even few KB.
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to address@hidden For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"address@hidden"> address@hidden </a>
- [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement, Wei Wang, 2017/12/19
- [Qemu-devel] [PATCH v20 1/7] xbitmap: Introduce xbitmap, Wei Wang, 2017/12/19
- [Qemu-devel] [PATCH v20 2/7] xbitmap: potential improvement, Wei Wang, 2017/12/19
- [Qemu-devel] [PATCH v20 3/7] xbitmap: add more operations, Wei Wang, 2017/12/19
- [Qemu-devel] [PATCH v20 5/7] mm: support reporting free page blocks, Wei Wang, 2017/12/19
- [Qemu-devel] [PATCH v20 4/7] virtio-balloon: VIRTIO_BALLOON_F_SG, Wei Wang, 2017/12/19
- [Qemu-devel] [PATCH v20 7/7] virtio-balloon: don't report free pages when page poisoning is enabled, Wei Wang, 2017/12/19
- [Qemu-devel] [PATCH v20 6/7] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ, Wei Wang, 2017/12/19
- Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement, Tetsuo Handa, 2017/12/19
- Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement,
Matthew Wilcox <=
- Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement, Michael S. Tsirkin, 2017/12/19
- Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement, Wei Wang, 2017/12/20
- Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement, Matthew Wilcox, 2017/12/20
- Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement, Wang, Wei W, 2017/12/20
- Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement, Matthew Wilcox, 2017/12/20
- Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement, Wei Wang, 2017/12/20
- Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement, Matthew Wilcox, 2017/12/21
- Re: [Qemu-devel] [PATCH v20 0/7] Virtio-balloon Enhancement, Tetsuo Handa, 2017/12/21