qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V2 4/5] pvrdma: initial implementation


From: Marcel Apfelbaum
Subject: Re: [Qemu-devel] [PATCH V2 4/5] pvrdma: initial implementation
Date: Wed, 20 Dec 2017 16:46:38 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

On 20/12/2017 6:08, Michael S. Tsirkin wrote:
On Tue, Dec 19, 2017 at 04:13:18PM -0300, Philippe Mathieu-Daudé wrote:
Hi Marcel, Yuval,

On Sun, Dec 17, 2017 at 9:54 AM, Marcel Apfelbaum <address@hidden> wrote:
From: Yuval Shaia <address@hidden>

PVRDMA is the QEMU implementation of VMware's paravirtualized RDMA device.
It works with its Linux Kernel driver AS IS, no need for any special guest
modifications.

While it complies with the VMware device, it can also communicate with bare
metal RDMA-enabled machines and does not require an RDMA HCA in the host, it
can work with Soft-RoCE (rxe).

It does not require the whole guest RAM to be pinned allowing memory
over-commit and, even if not implemented yet, migration support will be
possible with some HW assistance.

Signed-off-by: Yuval Shaia <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>
---
[...]
  28 files changed, 5132 insertions(+), 4 deletions(-)
  create mode 100644 hw/net/pvrdma/pvrdma.h
  create mode 100644 hw/net/pvrdma/pvrdma_backend.c
  create mode 100644 hw/net/pvrdma/pvrdma_backend.h
  create mode 100644 hw/net/pvrdma/pvrdma_backend_defs.h
  create mode 100644 hw/net/pvrdma/pvrdma_cmd.c
  create mode 100644 hw/net/pvrdma/pvrdma_defs.h
  create mode 100644 hw/net/pvrdma/pvrdma_dev_api.h
  create mode 100644 hw/net/pvrdma/pvrdma_dev_ring.c
  create mode 100644 hw/net/pvrdma/pvrdma_dev_ring.h
  create mode 100644 hw/net/pvrdma/pvrdma_ib_verbs.h
  create mode 100644 hw/net/pvrdma/pvrdma_main.c
  create mode 100644 hw/net/pvrdma/pvrdma_qp_ops.c
  create mode 100644 hw/net/pvrdma/pvrdma_qp_ops.h
  create mode 100644 hw/net/pvrdma/pvrdma_ring.h
  create mode 100644 hw/net/pvrdma/pvrdma_rm.c
  create mode 100644 hw/net/pvrdma/pvrdma_rm.h
  create mode 100644 hw/net/pvrdma/pvrdma_rm_defs.h
  create mode 100644 hw/net/pvrdma/pvrdma_types.h
  create mode 100644 hw/net/pvrdma/pvrdma_utils.c
  create mode 100644 hw/net/pvrdma/pvrdma_utils.h
  create mode 100644 hw/net/pvrdma/trace-events
[...]

Since we already have a hw/xenpv/ directory,

But e.g. xen nic is under hw/net/

can we place these files
into hw/vmwarepv/ rather than hw/net/pvrdma/?

A smarter move might be to create a hw/pv/ dir and have hw/pv/{xen,vmware}.

Regards,

Phil.

That's not how we layout things. We group them by function not by
interface. Thus I think that hw/rdma/ is better.



Hi Philippe and Michael,

Thanks for the suggestion, we will move the code to hw/rdma.
Marcel





reply via email to

[Prev in Thread] Current Thread [Next in Thread]