[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v6 07/27] monitor: unify global init
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC v6 07/27] monitor: unify global init |
Date: |
Wed, 20 Dec 2017 16:42:56 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Tue, Dec 19, 2017 at 04:45:37PM +0800, Peter Xu wrote:
> There are many places for monitor init its globals, at least:
>
> - monitor_init_qmp_commands() at the very beginning
> - single function to init monitor_lock
> - in the first entry of monitor_init() using "is_first_init"
>
> Unify them a bit.
>
> Reviewed-by: Fam Zheng <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> include/monitor/monitor.h | 2 +-
> monitor.c | 25 ++++++++++---------------
> vl.c | 7 ++++++-
> 3 files changed, 17 insertions(+), 17 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [RFC v6 01/27] chardev: use backend chr context when watch for fe, (continued)
- [Qemu-devel] [RFC v6 02/27] qobject: introduce qstring_get_try_str(), Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 03/27] qobject: introduce qobject_get_try_str(), Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 04/27] qobject: let object_property_get_str() use new API, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 05/27] monitor: move skip_flush into monitor_data_init, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 06/27] monitor: move the cur_mon hack deeper for QMP, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 07/27] monitor: unify global init, Peter Xu, 2017/12/19
- Re: [Qemu-devel] [RFC v6 07/27] monitor: unify global init,
Stefan Hajnoczi <=
- [Qemu-devel] [RFC v6 08/27] monitor: let mon_list be tail queue, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 09/27] monitor: create monitor dedicate iothread, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 10/27] monitor: allow to use IO thread for parsing, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 11/27] qmp: introduce QMPCapability, Peter Xu, 2017/12/19
- [Qemu-devel] [RFC v6 12/27] qmp: negotiate QMP capabilities, Peter Xu, 2017/12/19