[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 13/13] qmp: remove qmp_cpu
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 13/13] qmp: remove qmp_cpu |
Date: |
Wed, 20 Dec 2017 19:59:24 +0100 |
From: Daniel Henrique Barboza <address@hidden>
'qmp_cpu' was implemented in commit 755f196898 ("qapi: Convert the cpu
command") as a functional no-op, a QMP call that does nothing and
return success. The idea, apparently, was to provide a counterpart
for the HMP 'hmp_cpu' command, introduced in the same commit.
After 6 years of its creation, qmp_cpu remains a functional no-op
that does nothing, having no value for any caller/user. A proposal
was sent to implement qmp_cpu like hmp_cpu works, but it was denied
[1]. The reason is that QMP must be as stateless as possible and a
function that changes its state (the current CPU monitor in the case
of qmp_cpu) goes against it. Any QMP command that needs a specific
monitor CPU setup must provide it in its arguments, instead of relying
in the current QMP monitor state.
After discussions that happened in [2] it was decided that a command
that does nothing since its birth, no one uses for anything and will
not be implemented, should be deprecated and erased. Given that we will
*not* provide any replacement for qmp_cpu and we believe that there
is no user relying on it, there is no point in adding a deprecation
delay for it.
So, this patch nukes qmp_cpu from QEMU code, removing both its blank
implementation in qmp.c and its doc in qapi-schema.json.
[1] https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg02283.html
[2] https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg03696.html
Signed-off-by: Daniel Henrique Barboza <address@hidden>
CC: Markus Armbruster <address@hidden>
CC: Eric Blake <address@hidden>
CC: Daniel P. Berrange <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
qapi-schema.json | 11 -----------
qmp.c | 5 -----
2 files changed, 16 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index ea3723f903..5c06745c79 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1046,17 +1046,6 @@
{ 'command': 'system_powerdown' }
##
-# @cpu:
-#
-# This command is a nop that is only provided for the purposes of
compatibility.
-#
-# Since: 0.14.0
-#
-# Notes: Do not use this command.
-##
-{ 'command': 'cpu', 'data': {'index': 'int'} }
-
-##
# @cpu-add:
#
# Adds CPU with specified ID
diff --git a/qmp.c b/qmp.c
index e8c303116a..52cfd2d81c 100644
--- a/qmp.c
+++ b/qmp.c
@@ -113,11 +113,6 @@ void qmp_system_powerdown(Error **erp)
qemu_system_powerdown_request();
}
-void qmp_cpu(int64_t index, Error **errp)
-{
- /* Just do nothing */
-}
-
void qmp_cpu_add(int64_t id, Error **errp)
{
MachineClass *mc;
--
2.13.6
- [Qemu-devel] [PULL 10/13] qapi: Rename QAPIDoc.parser, .section to ._parser, ._section, (continued)
- [Qemu-devel] [PULL 10/13] qapi: Rename QAPIDoc.parser, .section to ._parser, ._section, Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 09/13] qapi2texi: Simplify representation of section text, Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 06/13] qapi2texi: Clean up texi_sections(), Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 04/13] qapi: Make cur_doc local to QAPISchemaParser.__init__(), Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 12/13] qapi-docs: fix a comment typo, Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 08/13] qapi: Simplify representation of QAPIDoc section text, Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 02/13] qapi: Stop rejecting #optional, Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 01/13] qapi-schema: Fix query-vm-generation-id's doc comment markup, Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 11/13] qapi2texi: De-duplicate code to add blank line before symbol, Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 05/13] tests/qapi-schema/doc-bad-section: New, factored out of doc-good, Markus Armbruster, 2017/12/20
- [Qemu-devel] [PULL 13/13] qmp: remove qmp_cpu,
Markus Armbruster <=
- Re: [Qemu-devel] [PULL 00/13] QAPI patches for 2017-12-20, Peter Maydell, 2017/12/20