Re: [Qemu-devel] [PATCH] 9pfs: fix error path in pdu_submit()

[Eric Blake]

On 12/15/2017 10:42 AM, Greg Kurz wrote:
> If we receive an unsupported request id, we first decide to
> return -ENOTSUPP to the client, but since the request id
> causes is_read_only_op() to return false, we change the
> error to be -EROFS if the fsdev is read-only. This doesn't
> make sense since we don't know what the client asked for.
>
> This patch ensures that -EROFS can only be returned if the
> request id is supported.
>
> Signed-off-by: Greg Kurz <address@hidden>
> ---
>   hw/9pfs/9p.c |    6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org