qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 00/19] Initial support for Hypervisor.framework

From: no-reply
Subject: Re: [Qemu-devel] [PULL 00/19] Initial support for Hypervisor.framework
Date: Wed, 20 Dec 2017 11:16:45 -0800 (PST) 
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/19] Initial support for Hypervisor.framework

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
643fafd4b8 i386: hvf: cleanup x86_gen.h
2091c81635 i386: hvf: remove VM_PANIC from "in"
683e8fde69 i386: hvf: remove addr_t
3b42a270ce i386: hvf: simplify flag handling
110a232ff1 i386: hvf: abort on decoding error
2de62453eb i386: hvf: remove ZERO_INIT macro
f55c2b11d2 i386: hvf: remove more dead emulator code
6134854ce2 i386: hvf: unify register enums between HVF and the rest
eb61783ac4 i386: hvf: header cleanup
3c51048c74 i386: hvf: move all hvf files in the same directory
ae6b6b5710 i386: hvf: inject General Protection Fault when vmexit through vmcall
fd8fcdf003 i386: hvf: refactor event injection code for hvf
9a5274b8e5 i386: hvf: implement vga dirty page tracking
750a618681 i386: refactor KVM cpuid code so that it applies to hvf as well
31285c7884 i386: hvf: implement hvf_get_supported_cpuid
fff2f086bb i386: hvf: use new helper functions for put/get xsave
405850d791 i386: hvf: fix licensing issues; isolate task handling code (GPL 
v2-only)
6cada5b6e4 i386: hvf: add code base from Google's QEMU repository
1641428883 apic: add function to apic that will be used by hvf

=== OUTPUT BEGIN ===
Checking PATCH 1/19: apic: add function to apic that will be used by hvf...
Checking PATCH 2/19: i386: hvf: add code base from Google's QEMU repository...
ERROR: Macros with complex values should be enclosed in parenthesis
#376: FILE: include/sysemu/hvf.h:31:
+#define hvf_enabled() !hvf_disabled

ERROR: Error messages should not contain newlines
#669: FILE: target/i386/hvf-all.c:63:
+        error_report("Error: HV_ERROR\n");

ERROR: Error messages should not contain newlines
#672: FILE: target/i386/hvf-all.c:66:
+        error_report("Error: HV_BUSY\n");

ERROR: Error messages should not contain newlines
#675: FILE: target/i386/hvf-all.c:69:
+        error_report("Error: HV_BAD_ARGUMENT\n");

ERROR: Error messages should not contain newlines
#678: FILE: target/i386/hvf-all.c:72:
+        error_report("Error: HV_NO_RESOURCES\n");

ERROR: Error messages should not contain newlines
#681: FILE: target/i386/hvf-all.c:75:
+        error_report("Error: HV_NO_DEVICE\n");

ERROR: Error messages should not contain newlines
#684: FILE: target/i386/hvf-all.c:78:
+        error_report("Error: HV_UNSUPPORTED\n");

ERROR: Error messages should not contain newlines
#687: FILE: target/i386/hvf-all.c:81:
+        error_report("Unknown Error\n");

ERROR: Error messages should not contain newlines
#774: FILE: target/i386/hvf-all.c:168:
+            error_report("Failed to reset overlapping slot\n");

ERROR: Error messages should not contain newlines
#794: FILE: target/i386/hvf-all.c:188:
+        error_report("No free slots\n");

ERROR: Error messages should not contain newlines
#803: FILE: target/i386/hvf-all.c:197:
+        error_report("Error registering new memory slot\n");

ERROR: do not use C99 // comments
#833: FILE: target/i386/hvf-all.c:227:
+// TODO: taskswitch handling

WARNING: line over 80 characters
#873: FILE: target/i386/hvf-all.c:267:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ldt}}, 
REG_SEG_LDTR);

ERROR: space required before the open brace '{'
#873: FILE: target/i386/hvf-all.c:267:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ldt}}, 
REG_SEG_LDTR);

ERROR: space required after that close brace '}'
#873: FILE: target/i386/hvf-all.c:267:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ldt}}, 
REG_SEG_LDTR);

WARNING: line over 80 characters
#874: FILE: target/i386/hvf-all.c:268:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->es}}, 
REG_SEG_ES);

ERROR: space required before the open brace '{'
#874: FILE: target/i386/hvf-all.c:268:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->es}}, 
REG_SEG_ES);

ERROR: space required after that close brace '}'
#874: FILE: target/i386/hvf-all.c:268:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->es}}, 
REG_SEG_ES);

WARNING: line over 80 characters
#875: FILE: target/i386/hvf-all.c:269:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->cs}}, 
REG_SEG_CS);

ERROR: space required before the open brace '{'
#875: FILE: target/i386/hvf-all.c:269:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->cs}}, 
REG_SEG_CS);

ERROR: space required after that close brace '}'
#875: FILE: target/i386/hvf-all.c:269:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->cs}}, 
REG_SEG_CS);

WARNING: line over 80 characters
#876: FILE: target/i386/hvf-all.c:270:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ss}}, 
REG_SEG_SS);

ERROR: space required before the open brace '{'
#876: FILE: target/i386/hvf-all.c:270:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ss}}, 
REG_SEG_SS);

ERROR: space required after that close brace '}'
#876: FILE: target/i386/hvf-all.c:270:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ss}}, 
REG_SEG_SS);

WARNING: line over 80 characters
#877: FILE: target/i386/hvf-all.c:271:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ds}}, 
REG_SEG_DS);

ERROR: space required before the open brace '{'
#877: FILE: target/i386/hvf-all.c:271:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ds}}, 
REG_SEG_DS);

ERROR: space required after that close brace '}'
#877: FILE: target/i386/hvf-all.c:271:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ds}}, 
REG_SEG_DS);

WARNING: line over 80 characters
#878: FILE: target/i386/hvf-all.c:272:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->fs}}, 
REG_SEG_FS);

ERROR: space required before the open brace '{'
#878: FILE: target/i386/hvf-all.c:272:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->fs}}, 
REG_SEG_FS);

ERROR: space required after that close brace '}'
#878: FILE: target/i386/hvf-all.c:272:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->fs}}, 
REG_SEG_FS);

WARNING: line over 80 characters
#879: FILE: target/i386/hvf-all.c:273:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->gs}}, 
REG_SEG_GS);

ERROR: space required before the open brace '{'
#879: FILE: target/i386/hvf-all.c:273:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->gs}}, 
REG_SEG_GS);

ERROR: space required after that close brace '}'
#879: FILE: target/i386/hvf-all.c:273:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->gs}}, 
REG_SEG_GS);

ERROR: if this code is redundant consider removing it
#881: FILE: target/i386/hvf-all.c:275:
+#if 0

ERROR: line over 90 characters
#892: FILE: target/i386/hvf-all.c:286:
+static int task_switch_32(CPUState *cpu, x68_segment_selector tss_sel, 
x68_segment_selector old_tss_sel,

WARNING: line over 80 characters
#893: FILE: target/i386/hvf-all.c:287:
+                          uint64_t old_tss_base, struct x86_segment_descriptor 
*new_desc)

ERROR: line over 90 characters
#903: FILE: target/i386/hvf-all.c:297:
+    vmx_write_mem(cpu, old_tss_base + eip_offset, &tss_seg.eip, ldt_sel_offset 
- eip_offset);

WARNING: line over 80 characters
#909: FILE: target/i386/hvf-all.c:303:
+        vmx_write_mem(cpu, new_tss_base, &tss_seg.prev_tss, 
sizeof(tss_seg.prev_tss));

ERROR: line over 90 characters
#915: FILE: target/i386/hvf-all.c:309:
+static void vmx_handle_task_switch(CPUState *cpu, x68_segment_selector 
tss_sel, int reason, bool gate_valid, uint8_t gate, uint64_t gate_type)

WARNING: line over 80 characters
#930: FILE: target/i386/hvf-all.c:324:
+    x68_segment_selector old_tss_sel = vmx_read_segment_selector(cpu, 
REG_SEG_TR);

ERROR: braces {} are necessary for all arms of this statement
#946: FILE: target/i386/hvf-all.c:340:
+        if (tss_sel.rpl > dpl || cs.rpl > dpl)
[...]

ERROR: do not use C99 // comments
#947: FILE: target/i386/hvf-all.c:341:
+            ;//DPRINTF("emulate_gp");

ERROR: line over 90 characters
#951: FILE: target/i386/hvf-all.c:345:
+    if (!next_tss_desc.p || ((desc_limit < 0x67 && (next_tss_desc.type & 8)) 
|| desc_limit < 0x2b)) {

ERROR: braces {} are necessary for all arms of this statement
#960: FILE: target/i386/hvf-all.c:354:
+    if (reason == TSR_IRET)
[...]

ERROR: braces {} are necessary for all arms of this statement
#963: FILE: target/i386/hvf-all.c:357:
+    if (reason != TSR_CALL && reason != TSR_IDT_GATE)
[...]

ERROR: braces {} are necessary for all arms of this statement
#971: FILE: target/i386/hvf-all.c:365:
+    if (next_tss_desc.type & 8)
[...]
+    else
[...]

WARNING: line over 80 characters
#972: FILE: target/i386/hvf-all.c:366:
+        ret = task_switch_32(cpu, tss_sel, old_tss_sel, old_tss_base, 
&next_tss_desc);

WARNING: line over 80 characters
#974: FILE: target/i386/hvf-all.c:368:
+        //ret = task_switch_16(cpu, tss_sel, old_tss_sel, old_tss_base, 
&next_tss_desc);

ERROR: do not use C99 // comments
#974: FILE: target/i386/hvf-all.c:368:
+        //ret = task_switch_16(cpu, tss_sel, old_tss_sel, old_tss_base, 
&next_tss_desc);

ERROR: "foo * bar" should be "foo *bar"
#987: FILE: target/i386/hvf-all.c:381:
+static void hvf_handle_interrupt(CPUState * cpu, int mask)

WARNING: line over 80 characters
#1027: FILE: target/i386/hvf-all.c:421:
+static void do_hvf_cpu_synchronize_post_reset(CPUState *cpu, run_on_cpu_data 
arg)

ERROR: open brace '{' following function declarations go on the next line
#1099: FILE: target/i386/hvf-all.c:493:
+void hvf_reset_vcpu(CPUState *cpu) {

WARNING: line over 80 characters
#1252: FILE: target/i386/hvf-all.c:646:
+    wvmcs(cpu->hvf_fd, VMCS_ENTRY_CTLS, 
cap2ctrl(hvf_state->hvf_caps->vmx_cap_entry,

ERROR: Error messages should not contain newlines
#1514: FILE: target/i386/hvf-all.c:908:
+                error_report("Unrecognized CR %d\n", cr);

ERROR: Error messages should not contain newlines
#1558: FILE: target/i386/hvf-all.c:952:
+            error_report("%llx: unhandled exit %llx\n", rip, exit_reason);

ERROR: trailing whitespace
#1578: FILE: target/i386/hvf-all.c:972:
+ $

ERROR: trailing whitespace
#1584: FILE: target/i386/hvf-all.c:978:
+  $

ERROR: trailing whitespace
#2368: FILE: target/i386/hvf-utils/x86.c:84:
+    $

ERROR: trailing whitespace
#2376: FILE: target/i386/hvf-utils/x86.c:92:
+    $

WARNING: line over 80 characters
#2942: FILE: target/i386/hvf-utils/x86.h:468:
+                         "shl $32,%%rdx; "  /* shift higher 32 bits stored in 
rdx up */

ERROR: trailing whitespace
#3023: FILE: target/i386/hvf-utils/x86_decode.c:67:
+    $

ERROR: trailing whitespace
#3037: FILE: target/i386/hvf-utils/x86_decode.c:81:
+    $

WARNING: line over 80 characters
#3166: FILE: target/i386/hvf-utils/x86_decode.c:210:
+    uint8_t op = (decode->opcode_len > 1) ? decode->opcode[1] : 
decode->opcode[0];

ERROR: trailing whitespace
#3167: FILE: target/i386/hvf-utils/x86_decode.c:211:
+    $

WARNING: line over 80 characters
#3193: FILE: target/i386/hvf-utils/x86_decode.c:237:
+    uint8_t op = (decode->opcode_len > 1) ? decode->opcode[1] : 
decode->opcode[0];

ERROR: trailing whitespace
#3194: FILE: target/i386/hvf-utils/x86_decode.c:238:
+    $

ERROR: trailing whitespace
#3417: FILE: target/i386/hvf-utils/x86_decode.c:461:
+    $

ERROR: trailing whitespace
#3424: FILE: target/i386/hvf-utils/x86_decode.c:468:
+    $

ERROR: trailing whitespace
#3432: FILE: target/i386/hvf-utils/x86_decode.c:476:
+    $

WARNING: line over 80 characters
#4944: FILE: target/i386/hvf-utils/x86_decode.c:1988:
+static inline void decode_displacement(CPUX86State *env, struct x86_decode 
*decode)

ERROR: trailing whitespace
#4949: FILE: target/i386/hvf-utils/x86_decode.c:1993:
+    $

ERROR: trailing whitespace
#5063: FILE: target/i386/hvf-utils/x86_decode.c:2107:
+    $

ERROR: trailing whitespace
#5072: FILE: target/i386/hvf-utils/x86_decode.c:2116:
+    $

WARNING: line over 80 characters
#5141: FILE: target/i386/hvf-utils/x86_decode.c:2185:
+    return linear_addr_size(ENV_GET_CPU(env), addr, decode->addressing_size, 
seg);

ERROR: trailing whitespace
#5198: FILE: target/i386/hvf-utils/x86_decode.h:50:
+    $

ERROR: trailing whitespace
#5329: FILE: target/i386/hvf-utils/x86_decode.h:181:
+    $

WARNING: line over 80 characters
#5542: FILE: target/i386/hvf-utils/x86_descr.c:63:
+x68_segment_selector vmx_read_segment_selector(CPUState *cpu, x86_reg_segment 
seg)

ERROR: line over 90 characters
#5549: FILE: target/i386/hvf-utils/x86_descr.c:70:
+void vmx_write_segment_selector(struct CPUState *cpu, x68_segment_selector 
selector, x86_reg_segment seg)

ERROR: line over 90 characters
#5554: FILE: target/i386/hvf-utils/x86_descr.c:75:
+void vmx_read_segment_descriptor(struct CPUState *cpu, struct vmx_segment 
*desc, x86_reg_segment seg)

ERROR: line over 90 characters
#5562: FILE: target/i386/hvf-utils/x86_descr.c:83:
+void vmx_write_segment_descriptor(CPUState *cpu, struct vmx_segment *desc, 
x86_reg_segment seg)

ERROR: line over 90 characters
#5572: FILE: target/i386/hvf-utils/x86_descr.c:93:
+void x86_segment_descriptor_to_vmx(struct CPUState *cpu, x68_segment_selector 
selector, struct x86_segment_descriptor *desc, struct vmx_segment *vmx_desc)

ERROR: line over 90 characters
#5589: FILE: target/i386/hvf-utils/x86_descr.c:110:
+void vmx_segment_to_x86_descriptor(struct CPUState *cpu, struct vmx_segment 
*vmx_desc, struct x86_segment_descriptor *desc)

ERROR: trailing whitespace
#5593: FILE: target/i386/hvf-utils/x86_descr.c:114:
+    $

ERROR: do not use C99 // comments
#5689: FILE: target/i386/hvf-utils/x86_emu.c:19:
+/////////////////////////////////////////////////////////////////////////

ERROR: do not use C99 // comments
#5690: FILE: target/i386/hvf-utils/x86_emu.c:20:
+//

ERROR: do not use C99 // comments
#5691: FILE: target/i386/hvf-utils/x86_emu.c:21:
+//  Copyright (C) 2001-2012  The Bochs Project

ERROR: do not use C99 // comments
#5692: FILE: target/i386/hvf-utils/x86_emu.c:22:
+//

ERROR: do not use C99 // comments
#5693: FILE: target/i386/hvf-utils/x86_emu.c:23:
+//  This library is free software; you can redistribute it and/or

ERROR: do not use C99 // comments
#5694: FILE: target/i386/hvf-utils/x86_emu.c:24:
+//  modify it under the terms of the GNU Lesser General Public

ERROR: do not use C99 // comments
#5695: FILE: target/i386/hvf-utils/x86_emu.c:25:
+//  License as published by the Free Software Foundation; either

ERROR: do not use C99 // comments
#5696: FILE: target/i386/hvf-utils/x86_emu.c:26:
+//  version 2 of the License, or (at your option) any later version.

ERROR: do not use C99 // comments
#5697: FILE: target/i386/hvf-utils/x86_emu.c:27:
+//

ERROR: do not use C99 // comments
#5698: FILE: target/i386/hvf-utils/x86_emu.c:28:
+//  This library is distributed in the hope that it will be useful,

ERROR: do not use C99 // comments
#5699: FILE: target/i386/hvf-utils/x86_emu.c:29:
+//  but WITHOUT ANY WARRANTY; without even the implied warranty of

ERROR: do not use C99 // comments
#5700: FILE: target/i386/hvf-utils/x86_emu.c:30:
+//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU

ERROR: do not use C99 // comments
#5701: FILE: target/i386/hvf-utils/x86_emu.c:31:
+//  Lesser General Public License for more details.

ERROR: do not use C99 // comments
#5702: FILE: target/i386/hvf-utils/x86_emu.c:32:
+//

ERROR: do not use C99 // comments
#5703: FILE: target/i386/hvf-utils/x86_emu.c:33:
+//  You should have received a copy of the GNU Lesser General Public

ERROR: do not use C99 // comments
#5704: FILE: target/i386/hvf-utils/x86_emu.c:34:
+//  License along with this library; if not, write to the Free Software

ERROR: do not use C99 // comments
#5705: FILE: target/i386/hvf-utils/x86_emu.c:35:
+//  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA B 02110-1301 USA

ERROR: do not use C99 // comments
#5706: FILE: target/i386/hvf-utils/x86_emu.c:36:
+/////////////////////////////////////////////////////////////////////////

ERROR: externs should be avoided in .c files
#5719: FILE: target/i386/hvf-utils/x86_emu.c:49:
+void hvf_handle_io(struct CPUState *cpu, uint16_t port, void *data,

ERROR: trailing whitespace
#5847: FILE: target/i386/hvf-utils/x86_emu.c:177:
+    $

WARNING: line over 80 characters
#5891: FILE: target/i386/hvf-utils/x86_emu.c:221:
+    return (ptr - (addr_t)&env->hvf_emul->regs[0]) < 
sizeof(env->hvf_emul->regs);

ERROR: spaces required around that '+' (ctx:WxV)
#6002: FILE: target/i386/hvf-utils/x86_emu.c:332:
+    EXEC_2OP_ARITH_CMD(env, decode, +get_CF(env)+, SET_FLAGS_OSZAPC_ADD, true);
                                     ^

ERROR: spaces required around that '+' (ctx:VxO)
#6002: FILE: target/i386/hvf-utils/x86_emu.c:332:
+    EXEC_2OP_ARITH_CMD(env, decode, +get_CF(env)+, SET_FLAGS_OSZAPC_ADD, true);
                                                 ^

ERROR: spaces required around that '-' (ctx:VxO)
#6008: FILE: target/i386/hvf-utils/x86_emu.c:338:
+    EXEC_2OP_ARITH_CMD(env, decode, -get_CF(env)-, SET_FLAGS_OSZAPC_SUB, true);
                                                 ^

ERROR: spaces required around that '+' (ctx:WxV)
#6064: FILE: target/i386/hvf-utils/x86_emu.c:394:
+    EXEC_2OP_ARITH_CMD(env, decode, +1+, SET_FLAGS_OSZAP_ADD, true);
                                     ^

ERROR: spaces required around that '+' (ctx:VxO)
#6064: FILE: target/i386/hvf-utils/x86_emu.c:394:
+    EXEC_2OP_ARITH_CMD(env, decode, +1+, SET_FLAGS_OSZAP_ADD, true);
                                       ^

ERROR: spaces required around that '-' (ctx:VxO)
#6074: FILE: target/i386/hvf-utils/x86_emu.c:404:
+    EXEC_2OP_ARITH_CMD(env, decode, -1-, SET_FLAGS_OSZAP_SUB, true);
                                       ^

WARNING: line over 80 characters
#6127: FILE: target/i386/hvf-utils/x86_emu.c:457:
+        hvf_handle_io(ENV_GET_CPU(env), DX(env), &RAX(env), 1, 
decode->operand_size, 1);

ERROR: line over 90 characters
#6144: FILE: target/i386/hvf-utils/x86_emu.c:474:
+        hvf_handle_io(ENV_GET_CPU(env), decode->op[0].val, &val, 0, 
decode->operand_size, 1);

WARNING: line over 80 characters
#6155: FILE: target/i386/hvf-utils/x86_emu.c:485:
+        hvf_handle_io(ENV_GET_CPU(env), DX(env), &val, 0, 
decode->operand_size, 1);

WARNING: line over 80 characters
#6183: FILE: target/i386/hvf-utils/x86_emu.c:513:
+static inline void string_rep(struct CPUX86State *env, struct x86_decode 
*decode,

WARNING: line over 80 characters
#6202: FILE: target/i386/hvf-utils/x86_emu.c:532:
+    addr_t addr = linear_addr_size(ENV_GET_CPU(env), RDI(env), 
decode->addressing_size,

WARNING: line over 80 characters
#6207: FILE: target/i386/hvf-utils/x86_emu.c:537:
+    vmx_write_mem(ENV_GET_CPU(env), addr, env->hvf_emul->mmio_buf, 
decode->operand_size);

WARNING: line over 80 characters
#6227: FILE: target/i386/hvf-utils/x86_emu.c:557:
+    vmx_read_mem(ENV_GET_CPU(env), env->hvf_emul->mmio_buf, addr, 
decode->operand_size);

WARNING: line over 80 characters
#6252: FILE: target/i386/hvf-utils/x86_emu.c:582:
+    dst_addr = linear_addr_size(ENV_GET_CPU(env), RDI(env), 
decode->addressing_size,

WARNING: line over 80 characters
#6279: FILE: target/i386/hvf-utils/x86_emu.c:609:
+    dst_addr = linear_addr_size(ENV_GET_CPU(env), RDI(env), 
decode->addressing_size,

ERROR: line over 90 characters
#6309: FILE: target/i386/hvf-utils/x86_emu.c:639:
+    addr = linear_addr_size(ENV_GET_CPU(env), RDI(env), 
decode->addressing_size, REG_SEG_ES);

ERROR: line over 90 characters
#6332: FILE: target/i386/hvf-utils/x86_emu.c:662:
+    addr = linear_addr_size(ENV_GET_CPU(env), RDI(env), 
decode->addressing_size, REG_SEG_ES);

WARNING: line over 80 characters
#6334: FILE: target/i386/hvf-utils/x86_emu.c:664:
+    vmx_read_mem(ENV_GET_CPU(env), &decode->op[1].val, addr, 
decode->operand_size);

ERROR: unnecessary whitespace before a quoted newline
#7188: FILE: target/i386/hvf-utils/x86_emu.c:1518:
+            printf("Unimplemented handler (%llx) for %d (%x %x) \n", RIP(env),

ERROR: unnecessary whitespace before a quoted newline
#7196: FILE: target/i386/hvf-utils/x86_emu.c:1526:
+                "Unimplemented handler (%llx) for %d (%x %x) \n", RIP(env),

WARNING: architecture specific defines should be avoided
#7231: FILE: target/i386/hvf-utils/x86_emu.h:18:
+#ifndef __X86_EMU_H__

ERROR: do not use C99 // comments
#7269: FILE: target/i386/hvf-utils/x86_flags.c:1:
+/////////////////////////////////////////////////////////////////////////

ERROR: do not use C99 // comments
#7270: FILE: target/i386/hvf-utils/x86_flags.c:2:
+//

ERROR: do not use C99 // comments
#7271: FILE: target/i386/hvf-utils/x86_flags.c:3:
+//  Copyright (C) 2001-2012  The Bochs Project

ERROR: do not use C99 // comments
#7272: FILE: target/i386/hvf-utils/x86_flags.c:4:
+//  Copyright (C) 2017 Google Inc.

ERROR: do not use C99 // comments
#7273: FILE: target/i386/hvf-utils/x86_flags.c:5:
+//

ERROR: do not use C99 // comments
#7274: FILE: target/i386/hvf-utils/x86_flags.c:6:
+//  This library is free software; you can redistribute it and/or

ERROR: do not use C99 // comments
#7275: FILE: target/i386/hvf-utils/x86_flags.c:7:
+//  modify it under the terms of the GNU Lesser General Public

ERROR: do not use C99 // comments
#7276: FILE: target/i386/hvf-utils/x86_flags.c:8:
+//  License as published by the Free Software Foundation; either

ERROR: do not use C99 // comments
#7277: FILE: target/i386/hvf-utils/x86_flags.c:9:
+//  version 2 of the License, or (at your option) any later version.

ERROR: do not use C99 // comments
#7278: FILE: target/i386/hvf-utils/x86_flags.c:10:
+//

ERROR: do not use C99 // comments
#7279: FILE: target/i386/hvf-utils/x86_flags.c:11:
+//  This library is distributed in the hope that it will be useful,

ERROR: do not use C99 // comments
#7280: FILE: target/i386/hvf-utils/x86_flags.c:12:
+//  but WITHOUT ANY WARRANTY; without even the implied warranty of

ERROR: do not use C99 // comments
#7281: FILE: target/i386/hvf-utils/x86_flags.c:13:
+//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU

ERROR: do not use C99 // comments
#7282: FILE: target/i386/hvf-utils/x86_flags.c:14:
+//  Lesser General Public License for more details.

ERROR: do not use C99 // comments
#7283: FILE: target/i386/hvf-utils/x86_flags.c:15:
+//

ERROR: do not use C99 // comments
#7284: FILE: target/i386/hvf-utils/x86_flags.c:16:
+//  You should have received a copy of the GNU Lesser General Public

ERROR: do not use C99 // comments
#7285: FILE: target/i386/hvf-utils/x86_flags.c:17:
+//  License along with this library; if not, write to the Free Software

ERROR: do not use C99 // comments
#7286: FILE: target/i386/hvf-utils/x86_flags.c:18:
+//  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA B 02110-1301 USA

ERROR: do not use C99 // comments
#7287: FILE: target/i386/hvf-utils/x86_flags.c:19:
+/////////////////////////////////////////////////////////////////////////

WARNING: line over 80 characters
#7501: FILE: target/i386/hvf-utils/x86_flags.c:233:
+    return ((env->hvf_emul->lflags.auxbits + (1U << LF_BIT_PO)) >> LF_BIT_CF) 
& 1;

ERROR: do not use C99 // comments
#7608: FILE: target/i386/hvf-utils/x86_flags.h:1:
+/////////////////////////////////////////////////////////////////////////

ERROR: do not use C99 // comments
#7609: FILE: target/i386/hvf-utils/x86_flags.h:2:
+//

ERROR: do not use C99 // comments
#7610: FILE: target/i386/hvf-utils/x86_flags.h:3:
+//  Copyright (C) 2001-2012  The Bochs Project

ERROR: do not use C99 // comments
#7611: FILE: target/i386/hvf-utils/x86_flags.h:4:
+//  Copyright (C) 2017 Google Inc.

ERROR: do not use C99 // comments
#7612: FILE: target/i386/hvf-utils/x86_flags.h:5:
+//

ERROR: do not use C99 // comments
#7613: FILE: target/i386/hvf-utils/x86_flags.h:6:
+//  This library is free software; you can redistribute it and/or

ERROR: do not use C99 // comments
#7614: FILE: target/i386/hvf-utils/x86_flags.h:7:
+//  modify it under the terms of the GNU Lesser General Public

ERROR: do not use C99 // comments
#7615: FILE: target/i386/hvf-utils/x86_flags.h:8:
+//  License as published by the Free Software Foundation; either

ERROR: do not use C99 // comments
#7616: FILE: target/i386/hvf-utils/x86_flags.h:9:
+//  version 2 of the License, or (at your option) any later version.

ERROR: do not use C99 // comments
#7617: FILE: target/i386/hvf-utils/x86_flags.h:10:
+//

ERROR: do not use C99 // comments
#7618: FILE: target/i386/hvf-utils/x86_flags.h:11:
+//  This library is distributed in the hope that it will be useful,

ERROR: do not use C99 // comments
#7619: FILE: target/i386/hvf-utils/x86_flags.h:12:
+//  but WITHOUT ANY WARRANTY; without even the implied warranty of

ERROR: do not use C99 // comments
#7620: FILE: target/i386/hvf-utils/x86_flags.h:13:
+//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU

ERROR: do not use C99 // comments
#7621: FILE: target/i386/hvf-utils/x86_flags.h:14:
+//  Lesser General Public License for more details.

ERROR: do not use C99 // comments
#7622: FILE: target/i386/hvf-utils/x86_flags.h:15:
+//

ERROR: do not use C99 // comments
#7623: FILE: target/i386/hvf-utils/x86_flags.h:16:
+//  You should have received a copy of the GNU Lesser General Public

ERROR: do not use C99 // comments
#7624: FILE: target/i386/hvf-utils/x86_flags.h:17:
+//  License along with this library; if not, write to the Free Software

ERROR: do not use C99 // comments
#7625: FILE: target/i386/hvf-utils/x86_flags.h:18:
+//  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA B 02110-1301 USA

ERROR: do not use C99 // comments
#7626: FILE: target/i386/hvf-utils/x86_flags.h:19:
+/////////////////////////////////////////////////////////////////////////

WARNING: architecture specific defines should be avoided
#7630: FILE: target/i386/hvf-utils/x86_flags.h:23:
+#ifndef __X86_FLAGS_H__

WARNING: architecture specific defines should be avoided
#7874: FILE: target/i386/hvf-utils/x86_gen.h:18:
+#ifndef __X86_GEN_H__

WARNING: line over 80 characters
#7985: FILE: target/i386/hvf-utils/x86_mmu.c:70:
+    return (addr >> (level_shift * (level - 1) + 12)) & ((1 << level_shift) - 
1);

ERROR: trailing whitespace
#8063: FILE: target/i386/hvf-utils/x86_mmu.c:148:
+    $

ERROR: trailing whitespace
#8095: FILE: target/i386/hvf-utils/x86_mmu.c:180:
+    $

ERROR: trailing whitespace
#8104: FILE: target/i386/hvf-utils/x86_mmu.c:189:
+    $

WARNING: architecture specific defines should be avoided
#8212: FILE: target/i386/hvf-utils/x86_mmu.h:18:
+#ifndef __X86_MMU_H__

ERROR: trailing whitespace
#8326: FILE: target/i386/hvf-utils/x86hvf.c:81:
+    $

ERROR: trailing whitespace
#8328: FILE: target/i386/hvf-utils/x86hvf.c:83:
+    memset(xsave, 0, sizeof(*xsave)); $

ERROR: trailing whitespace
#8329: FILE: target/i386/hvf-utils/x86hvf.c:84:
+    $

ERROR: line over 90 characters
#8330: FILE: target/i386/hvf-utils/x86hvf.c:85:
+    memcpy(&xsave->data[4], &X86_CPU(cpu_state)->env.fpdp, 
sizeof(X86_CPU(cpu_state)->env.fpdp));

ERROR: line over 90 characters
#8331: FILE: target/i386/hvf-utils/x86hvf.c:86:
+    memcpy(&xsave->data[2], &X86_CPU(cpu_state)->env.fpip, 
sizeof(X86_CPU(cpu_state)->env.fpip));

ERROR: line over 90 characters
#8332: FILE: target/i386/hvf-utils/x86hvf.c:87:
+    memcpy(&xsave->data[8], &X86_CPU(cpu_state)->env.fpregs, 
sizeof(X86_CPU(cpu_state)->env.fpregs));

ERROR: line over 90 characters
#8333: FILE: target/i386/hvf-utils/x86hvf.c:88:
+    memcpy(&xsave->data[144], &X86_CPU(cpu_state)->env.ymmh_regs, 
sizeof(X86_CPU(cpu_state)->env.ymmh_regs));

ERROR: line over 90 characters
#8334: FILE: target/i386/hvf-utils/x86hvf.c:89:
+    memcpy(&xsave->data[288], &X86_CPU(cpu_state)->env.zmmh_regs, 
sizeof(X86_CPU(cpu_state)->env.zmmh_regs));

ERROR: line over 90 characters
#8335: FILE: target/i386/hvf-utils/x86hvf.c:90:
+    memcpy(&xsave->data[272], &X86_CPU(cpu_state)->env.opmask_regs, 
sizeof(X86_CPU(cpu_state)->env.opmask_regs));

ERROR: line over 90 characters
#8336: FILE: target/i386/hvf-utils/x86hvf.c:91:
+    memcpy(&xsave->data[240], &X86_CPU(cpu_state)->env.bnd_regs, 
sizeof(X86_CPU(cpu_state)->env.bnd_regs));

ERROR: line over 90 characters
#8337: FILE: target/i386/hvf-utils/x86hvf.c:92:
+    memcpy(&xsave->data[256], &X86_CPU(cpu_state)->env.bndcs_regs, 
sizeof(X86_CPU(cpu_state)->env.bndcs_regs));

ERROR: line over 90 characters
#8338: FILE: target/i386/hvf-utils/x86hvf.c:93:
+    memcpy(&xsave->data[416], &X86_CPU(cpu_state)->env.hi16_zmm_regs, 
sizeof(X86_CPU(cpu_state)->env.hi16_zmm_regs));

ERROR: trailing whitespace
#8339: FILE: target/i386/hvf-utils/x86hvf.c:94:
+    $

ERROR: trailing whitespace
#8343: FILE: target/i386/hvf-utils/x86hvf.c:98:
+    $

ERROR: braces {} are necessary even for single statement blocks
#8344: FILE: target/i386/hvf-utils/x86hvf.c:99:
+    for (x = 0; x < 8; ++x)
+        xsave->data[1] |= ((!X86_CPU(cpu_state)->env.fptags[x]) << x);

ERROR: trailing whitespace
#8347: FILE: target/i386/hvf-utils/x86hvf.c:102:
+    $

ERROR: line over 90 characters
#8348: FILE: target/i386/hvf-utils/x86hvf.c:103:
+    memcpy(&xsave->data[40], &X86_CPU(cpu_state)->env.xmm_regs, 
sizeof(X86_CPU(cpu_state)->env.xmm_regs));

ERROR: trailing whitespace
#8349: FILE: target/i386/hvf-utils/x86hvf.c:104:
+    $

ERROR: trailing whitespace
#8352: FILE: target/i386/hvf-utils/x86hvf.c:107:
+    $

ERROR: space required before the open brace '{'
#8353: FILE: target/i386/hvf-utils/x86hvf.c:108:
+    if (hv_vcpu_write_fpstate(cpu_state->hvf_fd, xsave->data, 4096)){

ERROR: trailing whitespace
#8362: FILE: target/i386/hvf-utils/x86hvf.c:117:
+    $

ERROR: trailing whitespace
#8379: FILE: target/i386/hvf-utils/x86hvf.c:134:
+    $

ERROR: trailing whitespace
#8400: FILE: target/i386/hvf-utils/x86hvf.c:155:
+    $

ERROR: trailing whitespace
#8403: FILE: target/i386/hvf-utils/x86hvf.c:158:
+    $

ERROR: trailing whitespace
#8437: FILE: target/i386/hvf-utils/x86hvf.c:192:
+    $

ERROR: trailing whitespace
#8439: FILE: target/i386/hvf-utils/x86hvf.c:194:
+    $

ERROR: line over 90 characters
#8444: FILE: target/i386/hvf-utils/x86hvf.c:199:
+    memcpy(&X86_CPU(cpu_state)->env.fpdp, &xsave->data[4], 
sizeof(X86_CPU(cpu_state)->env.fpdp));

ERROR: line over 90 characters
#8445: FILE: target/i386/hvf-utils/x86hvf.c:200:
+    memcpy(&X86_CPU(cpu_state)->env.fpip, &xsave->data[2], 
sizeof(X86_CPU(cpu_state)->env.fpip));

ERROR: line over 90 characters
#8446: FILE: target/i386/hvf-utils/x86hvf.c:201:
+    memcpy(&X86_CPU(cpu_state)->env.fpregs, &xsave->data[8], 
sizeof(X86_CPU(cpu_state)->env.fpregs));

ERROR: line over 90 characters
#8447: FILE: target/i386/hvf-utils/x86hvf.c:202:
+    memcpy(&X86_CPU(cpu_state)->env.ymmh_regs, &xsave->data[144], 
sizeof(X86_CPU(cpu_state)->env.ymmh_regs));

ERROR: line over 90 characters
#8448: FILE: target/i386/hvf-utils/x86hvf.c:203:
+    memcpy(&X86_CPU(cpu_state)->env.zmmh_regs, &xsave->data[288], 
sizeof(X86_CPU(cpu_state)->env.zmmh_regs));

ERROR: line over 90 characters
#8449: FILE: target/i386/hvf-utils/x86hvf.c:204:
+    memcpy(&X86_CPU(cpu_state)->env.opmask_regs, &xsave->data[272], 
sizeof(X86_CPU(cpu_state)->env.opmask_regs));

ERROR: line over 90 characters
#8450: FILE: target/i386/hvf-utils/x86hvf.c:205:
+    memcpy(&X86_CPU(cpu_state)->env.bnd_regs, &xsave->data[240], 
sizeof(X86_CPU(cpu_state)->env.bnd_regs));

ERROR: line over 90 characters
#8451: FILE: target/i386/hvf-utils/x86hvf.c:206:
+    memcpy(&X86_CPU(cpu_state)->env.bndcs_regs, &xsave->data[256], 
sizeof(X86_CPU(cpu_state)->env.bndcs_regs));

ERROR: line over 90 characters
#8452: FILE: target/i386/hvf-utils/x86hvf.c:207:
+    memcpy(&X86_CPU(cpu_state)->env.hi16_zmm_regs, &xsave->data[416], 
sizeof(X86_CPU(cpu_state)->env.hi16_zmm_regs));

ERROR: trailing whitespace
#8453: FILE: target/i386/hvf-utils/x86hvf.c:208:
+    $

ERROR: trailing whitespace
#8454: FILE: target/i386/hvf-utils/x86hvf.c:209:
+    $

ERROR: trailing whitespace
#8459: FILE: target/i386/hvf-utils/x86hvf.c:214:
+    $

ERROR: suspect code indent for conditional statements (4, 7)
#8460: FILE: target/i386/hvf-utils/x86hvf.c:215:
+    for (x = 0; x < 8; ++x)
+       X86_CPU(cpu_state)->env.fptags[x] =

ERROR: trailing whitespace
#8463: FILE: target/i386/hvf-utils/x86hvf.c:218:
+    $

ERROR: line over 90 characters
#8464: FILE: target/i386/hvf-utils/x86hvf.c:219:
+    memcpy(&X86_CPU(cpu_state)->env.xmm_regs, &xsave->data[40], 
sizeof(X86_CPU(cpu_state)->env.xmm_regs));

ERROR: trailing whitespace
#8480: FILE: target/i386/hvf-utils/x86hvf.c:235:
+    $

ERROR: trailing whitespace
#8511: FILE: target/i386/hvf-utils/x86hvf.c:266:
+    $

ERROR: trailing whitespace
#8519: FILE: target/i386/hvf-utils/x86hvf.c:274:
+    $

ERROR: trailing whitespace
#8522: FILE: target/i386/hvf-utils/x86hvf.c:277:
+    $

ERROR: trailing whitespace
#8539: FILE: target/i386/hvf-utils/x86hvf.c:294:
+    $

ERROR: trailing whitespace
#8566: FILE: target/i386/hvf-utils/x86hvf.c:321:
+   $

ERROR: trailing whitespace
#8568: FILE: target/i386/hvf-utils/x86hvf.c:323:
+    $

ERROR: trailing whitespace
#8570: FILE: target/i386/hvf-utils/x86hvf.c:325:
+    $

ERROR: trailing whitespace
#8572: FILE: target/i386/hvf-utils/x86hvf.c:327:
+    $

ERROR: trailing whitespace
#8574: FILE: target/i386/hvf-utils/x86hvf.c:329:
+    $

ERROR: trailing whitespace
#8583: FILE: target/i386/hvf-utils/x86hvf.c:338:
+    $

ERROR: trailing whitespace
#8609: FILE: target/i386/hvf-utils/x86hvf.c:364:
+    $

ERROR: trailing whitespace
#8612: FILE: target/i386/hvf-utils/x86hvf.c:367:
+   $

ERROR: trailing whitespace
#8615: FILE: target/i386/hvf-utils/x86hvf.c:370:
+    $

ERROR: trailing whitespace
#8618: FILE: target/i386/hvf-utils/x86hvf.c:373:
+    $

ERROR: trailing whitespace
#8627: FILE: target/i386/hvf-utils/x86hvf.c:382:
+    $

ERROR: trailing whitespace
#8658: FILE: target/i386/hvf-utils/x86hvf.c:413:
+    $

ERROR: trailing whitespace
#8663: FILE: target/i386/hvf-utils/x86hvf.c:418:
+        $

ERROR: trailing whitespace
#8669: FILE: target/i386/hvf-utils/x86hvf.c:424:
+        $

ERROR: trailing whitespace
#8690: FILE: target/i386/hvf-utils/x86hvf.c:445:
+            $

total: 196 errors, 36 warnings, 8559 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/19: i386: hvf: fix licensing issues; isolate task handling 
code (GPL v2-only)...
ERROR: do not use C99 // comments
#553: FILE: target/i386/hvf-utils/x86_task.c:1:
+// This software is licensed under the terms of the GNU General Public

ERROR: do not use C99 // comments
#554: FILE: target/i386/hvf-utils/x86_task.c:2:
+// License version 2, as published by the Free Software Foundation, and

ERROR: do not use C99 // comments
#555: FILE: target/i386/hvf-utils/x86_task.c:3:
+// may be copied, distributed, and modified under those terms.

ERROR: trailing whitespace
#556: FILE: target/i386/hvf-utils/x86_task.c:4:
+// $

ERROR: do not use C99 // comments
#556: FILE: target/i386/hvf-utils/x86_task.c:4:
+// 

ERROR: do not use C99 // comments
#557: FILE: target/i386/hvf-utils/x86_task.c:5:
+// This program is distributed in the hope that it will be useful,

ERROR: do not use C99 // comments
#558: FILE: target/i386/hvf-utils/x86_task.c:6:
+// but WITHOUT ANY WARRANTY; without even the implied warranty of

ERROR: do not use C99 // comments
#559: FILE: target/i386/hvf-utils/x86_task.c:7:
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

ERROR: do not use C99 // comments
#560: FILE: target/i386/hvf-utils/x86_task.c:8:
+// GNU General Public License for more details.

ERROR: do not use C99 // comments
#592: FILE: target/i386/hvf-utils/x86_task.c:40:
+// TODO: taskswitch handling

WARNING: line over 80 characters
#638: FILE: target/i386/hvf-utils/x86_task.c:86:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ldt}}, 
REG_SEG_LDTR);

ERROR: space required before the open brace '{'
#638: FILE: target/i386/hvf-utils/x86_task.c:86:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ldt}}, 
REG_SEG_LDTR);

ERROR: space required after that close brace '}'
#638: FILE: target/i386/hvf-utils/x86_task.c:86:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ldt}}, 
REG_SEG_LDTR);

WARNING: line over 80 characters
#639: FILE: target/i386/hvf-utils/x86_task.c:87:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->es}}, 
REG_SEG_ES);

ERROR: space required before the open brace '{'
#639: FILE: target/i386/hvf-utils/x86_task.c:87:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->es}}, 
REG_SEG_ES);

ERROR: space required after that close brace '}'
#639: FILE: target/i386/hvf-utils/x86_task.c:87:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->es}}, 
REG_SEG_ES);

WARNING: line over 80 characters
#640: FILE: target/i386/hvf-utils/x86_task.c:88:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->cs}}, 
REG_SEG_CS);

ERROR: space required before the open brace '{'
#640: FILE: target/i386/hvf-utils/x86_task.c:88:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->cs}}, 
REG_SEG_CS);

ERROR: space required after that close brace '}'
#640: FILE: target/i386/hvf-utils/x86_task.c:88:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->cs}}, 
REG_SEG_CS);

WARNING: line over 80 characters
#641: FILE: target/i386/hvf-utils/x86_task.c:89:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ss}}, 
REG_SEG_SS);

ERROR: space required before the open brace '{'
#641: FILE: target/i386/hvf-utils/x86_task.c:89:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ss}}, 
REG_SEG_SS);

ERROR: space required after that close brace '}'
#641: FILE: target/i386/hvf-utils/x86_task.c:89:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ss}}, 
REG_SEG_SS);

WARNING: line over 80 characters
#642: FILE: target/i386/hvf-utils/x86_task.c:90:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ds}}, 
REG_SEG_DS);

ERROR: space required before the open brace '{'
#642: FILE: target/i386/hvf-utils/x86_task.c:90:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ds}}, 
REG_SEG_DS);

ERROR: space required after that close brace '}'
#642: FILE: target/i386/hvf-utils/x86_task.c:90:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ds}}, 
REG_SEG_DS);

WARNING: line over 80 characters
#643: FILE: target/i386/hvf-utils/x86_task.c:91:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->fs}}, 
REG_SEG_FS);

ERROR: space required before the open brace '{'
#643: FILE: target/i386/hvf-utils/x86_task.c:91:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->fs}}, 
REG_SEG_FS);

ERROR: space required after that close brace '}'
#643: FILE: target/i386/hvf-utils/x86_task.c:91:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->fs}}, 
REG_SEG_FS);

WARNING: line over 80 characters
#644: FILE: target/i386/hvf-utils/x86_task.c:92:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->gs}}, 
REG_SEG_GS);

ERROR: space required before the open brace '{'
#644: FILE: target/i386/hvf-utils/x86_task.c:92:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->gs}}, 
REG_SEG_GS);

ERROR: space required after that close brace '}'
#644: FILE: target/i386/hvf-utils/x86_task.c:92:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->gs}}, 
REG_SEG_GS);

ERROR: if this code is redundant consider removing it
#646: FILE: target/i386/hvf-utils/x86_task.c:94:
+#if 0

ERROR: line over 90 characters
#657: FILE: target/i386/hvf-utils/x86_task.c:105:
+static int task_switch_32(CPUState *cpu, x68_segment_selector tss_sel, 
x68_segment_selector old_tss_sel,

WARNING: line over 80 characters
#658: FILE: target/i386/hvf-utils/x86_task.c:106:
+                          uint64_t old_tss_base, struct x86_segment_descriptor 
*new_desc)

ERROR: line over 90 characters
#668: FILE: target/i386/hvf-utils/x86_task.c:116:
+    vmx_write_mem(cpu, old_tss_base + eip_offset, &tss_seg.eip, ldt_sel_offset 
- eip_offset);

WARNING: line over 80 characters
#674: FILE: target/i386/hvf-utils/x86_task.c:122:
+        vmx_write_mem(cpu, new_tss_base, &tss_seg.prev_tss, 
sizeof(tss_seg.prev_tss));

ERROR: line over 90 characters
#680: FILE: target/i386/hvf-utils/x86_task.c:128:
+void vmx_handle_task_switch(CPUState *cpu, x68_segment_selector tss_sel, int 
reason, bool gate_valid, uint8_t gate, uint64_t gate_type)

WARNING: line over 80 characters
#695: FILE: target/i386/hvf-utils/x86_task.c:143:
+    x68_segment_selector old_tss_sel = vmx_read_segment_selector(cpu, 
REG_SEG_TR);

ERROR: braces {} are necessary for all arms of this statement
#714: FILE: target/i386/hvf-utils/x86_task.c:162:
+        if (tss_sel.rpl > dpl || cs.rpl > dpl)
[...]

ERROR: do not use C99 // comments
#715: FILE: target/i386/hvf-utils/x86_task.c:163:
+            ;//DPRINTF("emulate_gp");

ERROR: line over 90 characters
#719: FILE: target/i386/hvf-utils/x86_task.c:167:
+    if (!next_tss_desc.p || ((desc_limit < 0x67 && (next_tss_desc.type & 8)) 
|| desc_limit < 0x2b)) {

ERROR: braces {} are necessary for all arms of this statement
#728: FILE: target/i386/hvf-utils/x86_task.c:176:
+    if (reason == TSR_IRET)
[...]

ERROR: braces {} are necessary for all arms of this statement
#731: FILE: target/i386/hvf-utils/x86_task.c:179:
+    if (reason != TSR_CALL && reason != TSR_IDT_GATE)
[...]

ERROR: braces {} are necessary for all arms of this statement
#739: FILE: target/i386/hvf-utils/x86_task.c:187:
+    if (next_tss_desc.type & 8)
[...]
+    else
[...]

WARNING: line over 80 characters
#740: FILE: target/i386/hvf-utils/x86_task.c:188:
+        ret = task_switch_32(cpu, tss_sel, old_tss_sel, old_tss_base, 
&next_tss_desc);

WARNING: line over 80 characters
#742: FILE: target/i386/hvf-utils/x86_task.c:190:
+        //ret = task_switch_16(cpu, tss_sel, old_tss_sel, old_tss_base, 
&next_tss_desc);

ERROR: do not use C99 // comments
#742: FILE: target/i386/hvf-utils/x86_task.c:190:
+        //ret = task_switch_16(cpu, tss_sel, old_tss_sel, old_tss_base, 
&next_tss_desc);

total: 35 errors, 12 warnings, 724 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/19: i386: hvf: use new helper functions for put/get xsave...
ERROR: "(foo*)" should be "(foo *)"
#89: FILE: target/i386/hvf-utils/x86hvf.c:85:
+    if (hv_vcpu_write_fpstate(cpu_state->hvf_fd, (void*)xsave, 4096)) {

ERROR: "(foo*)" should be "(foo *)"
#106: FILE: target/i386/hvf-utils/x86hvf.c:171:
+    if (hv_vcpu_read_fpstate(cpu_state->hvf_fd, (void*)xsave, 4096)) {

total: 2 errors, 0 warnings, 108 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/19: i386: hvf: implement hvf_get_supported_cpuid...
ERROR: return is not a function, parentheses are not required
#65: FILE: target/i386/hvf-utils/x86_cpuid.c:46:
+    return ((cap_exit & (1 << 23)) && (cap_entry & (1 << 16)));

WARNING: line over 80 characters
#154: FILE: target/i386/hvf-utils/x86_cpuid.c:135:
+                CPUID_EXT2_SYSCALL | CPUID_MTRR | CPUID_PGE | CPUID_MCA | 
CPUID_CMOV |

WARNING: line over 80 characters
#156: FILE: target/i386/hvf-utils/x86_cpuid.c:137:
+                CPUID_FXSR | CPUID_EXT2_FXSR | CPUID_EXT2_PDPE1GB | 
CPUID_EXT2_3DNOWEXT |

WARNING: line over 80 characters
#157: FILE: target/i386/hvf-utils/x86_cpuid.c:138:
+                CPUID_EXT2_3DNOW | CPUID_EXT2_LM | CPUID_EXT2_RDTSCP | 
CPUID_EXT2_NX;

total: 1 errors, 3 warnings, 164 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/19: i386: refactor KVM cpuid code so that it applies to hvf as 
well...
ERROR: else should follow close brace '}'
#197: FILE: target/i386/cpu.c:3297:
     }
+    else if (hvf_enabled()) {

total: 1 errors, 0 warnings, 204 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 7/19: i386: hvf: implement vga dirty page tracking...
Checking PATCH 8/19: i386: hvf: refactor event injection code for hvf...
WARNING: line over 80 characters
#38: FILE: target/i386/hvf-all.c:587:
+static void hvf_store_events(CPUState *cpu, uint32_t ins_len, uint64_t 
idtvec_info)

total: 0 errors, 1 warnings, 223 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 9/19: i386: hvf: inject General Protection Fault when vmexit 
through vmcall...
Checking PATCH 10/19: i386: hvf: move all hvf files in the same directory...
Checking PATCH 11/19: i386: hvf: header cleanup...
Checking PATCH 12/19: i386: hvf: unify register enums between HVF and the 
rest...
ERROR: line over 90 characters
#668: FILE: target/i386/hvf/x86_descr.c:71:
+void vmx_write_segment_selector(struct CPUState *cpu, x68_segment_selector 
selector, X86Seg seg)

ERROR: line over 90 characters
#674: FILE: target/i386/hvf/x86_descr.c:76:
+void vmx_read_segment_descriptor(struct CPUState *cpu, struct vmx_segment 
*desc, X86Seg seg)

WARNING: line over 80 characters
#683: FILE: target/i386/hvf/x86_descr.c:84:
+void vmx_write_segment_descriptor(CPUState *cpu, struct vmx_segment *desc, 
X86Seg seg)

WARNING: line over 80 characters
#834: FILE: target/i386/hvf/x86_emu.c:639:
+    addr = linear_addr_size(ENV_GET_CPU(env), RDI(env), 
decode->addressing_size, R_ES);

WARNING: line over 80 characters
#848: FILE: target/i386/hvf/x86_emu.c:662:
+    addr = linear_addr_size(ENV_GET_CPU(env), RDI(env), 
decode->addressing_size, R_ES);

ERROR: space required after that close brace '}'
#946: FILE: target/i386/hvf/x86_task.c:86:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ldt}}, 
R_LDTR);

ERROR: space required after that close brace '}'
#947: FILE: target/i386/hvf/x86_task.c:87:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->es}}, R_ES);

ERROR: space required after that close brace '}'
#948: FILE: target/i386/hvf/x86_task.c:88:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->cs}}, R_CS);

ERROR: space required after that close brace '}'
#949: FILE: target/i386/hvf/x86_task.c:89:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ss}}, R_SS);

ERROR: space required after that close brace '}'
#950: FILE: target/i386/hvf/x86_task.c:90:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->ds}}, R_DS);

ERROR: space required after that close brace '}'
#951: FILE: target/i386/hvf/x86_task.c:91:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->fs}}, R_FS);

ERROR: space required after that close brace '}'
#952: FILE: target/i386/hvf/x86_task.c:92:
+    vmx_write_segment_selector(cpu, (x68_segment_selector){{tss->gs}}, R_GS);

total: 9 errors, 3 warnings, 973 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 13/19: i386: hvf: remove more dead emulator code...
ERROR: unnecessary whitespace before a quoted newline
#149: FILE: target/i386/hvf/x86_emu.c:1514:
+        printf("Unimplemented handler (%llx) for %d (%x %x) \n", RIP(env),

total: 1 errors, 0 warnings, 182 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 14/19: i386: hvf: remove ZERO_INIT macro...
Checking PATCH 15/19: i386: hvf: abort on decoding error...
Checking PATCH 16/19: i386: hvf: simplify flag handling...
ERROR: spaces required around that '+' (ctx:WxV)
#121: FILE: target/i386/hvf/x86_emu.c:287:
+    EXEC_2OP_FLAGS_CMD(env, decode, +get_CF(env)+, SET_FLAGS_OSZAPC_ADD, true);
                                     ^

ERROR: spaces required around that '+' (ctx:VxO)
#121: FILE: target/i386/hvf/x86_emu.c:287:
+    EXEC_2OP_FLAGS_CMD(env, decode, +get_CF(env)+, SET_FLAGS_OSZAPC_ADD, true);
                                                 ^

ERROR: spaces required around that '-' (ctx:VxO)
#128: FILE: target/i386/hvf/x86_emu.c:293:
+    EXEC_2OP_FLAGS_CMD(env, decode, -get_CF(env)-, SET_FLAGS_OSZAPC_SUB, true);
                                                 ^

ERROR: spaces required around that '+' (ctx:WxV)
#189: FILE: target/i386/hvf/x86_emu.c:349:
+    EXEC_2OP_FLAGS_CMD(env, decode, +1+, SET_FLAGS_OSZAP_ADD, true);
                                     ^

ERROR: spaces required around that '+' (ctx:VxO)
#189: FILE: target/i386/hvf/x86_emu.c:349:
+    EXEC_2OP_FLAGS_CMD(env, decode, +1+, SET_FLAGS_OSZAP_ADD, true);
                                       ^

ERROR: spaces required around that '-' (ctx:VxO)
#198: FILE: target/i386/hvf/x86_emu.c:359:
+    EXEC_2OP_FLAGS_CMD(env, decode, -1-, SET_FLAGS_OSZAP_SUB, true);
                                       ^

WARNING: line over 80 characters
#576: FILE: target/i386/hvf/x86_flags.c:232:
+    return ((env->hvf_emul->lflags.auxbits + (1U << LF_BIT_PO)) >> LF_BIT_CF) 
& 1;

total: 6 errors, 1 warnings, 753 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 17/19: i386: hvf: remove addr_t...
WARNING: line over 80 characters
#122: FILE: target/i386/hvf/x86.h:384:
+target_ulong linear_addr(struct CPUState *cpu, target_ulong addr, enum X86Seg 
seg);

WARNING: line over 80 characters
#353: FILE: target/i386/hvf/x86_emu.c:176:
+    return (ptr - (target_ulong)&env->hvf_emul->regs[0]) < 
sizeof(env->hvf_emul->regs);

WARNING: line over 80 characters
#357: FILE: target/i386/hvf/x86_emu.c:179:
+void write_val_ext(struct CPUX86State *env, target_ulong ptr, target_ulong 
val, int size)

ERROR: line over 90 characters
#413: FILE: target/i386/hvf/x86_emu.c:487:
+    target_ulong addr = linear_addr_size(ENV_GET_CPU(env), RDI(env), 
decode->addressing_size,

WARNING: line over 80 characters
#500: FILE: target/i386/hvf/x86_emu.h:38:
+void write_val_ext(struct CPUX86State *env, target_ulong ptr, target_ulong 
val, int size);

WARNING: line over 80 characters
#547: FILE: target/i386/hvf/x86_flags.c:103:
+    target_ulong delta_c = (env->hvf_emul->lflags.auxbits ^ temp) & 
LF_MASK_CF; \

WARNING: line over 80 characters
#650: FILE: target/i386/hvf/x86_mmu.c:231:
+void vmx_write_mem(struct CPUState *cpu, target_ulong gva, void *data, int 
bytes)

WARNING: line over 80 characters
#682: FILE: target/i386/hvf/x86_mmu.h:42:
+void vmx_write_mem(struct CPUState *cpu, target_ulong gva, void *data, int 
bytes);

WARNING: line over 80 characters
#683: FILE: target/i386/hvf/x86_mmu.h:43:
+void vmx_read_mem(struct CPUState *cpu, void *data, target_ulong gva, int 
bytes);

total: 1 errors, 8 warnings, 575 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 18/19: i386: hvf: remove VM_PANIC from "in"...
Checking PATCH 19/19: i386: hvf: cleanup x86_gen.h...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
reply via email to
[Prev in Thread] Current Thread [Next in Thread]