[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] Add aarch64_be-linux-user target
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] Add aarch64_be-linux-user target |
Date: |
Tue, 19 Dec 2017 09:00:08 -0800 (PST) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/4] Add aarch64_be-linux-user target
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
5ac57ff210 configure: Add aarch64_be-linux-user target
07335652c6 linux-user: Fix endianess of aarch64 signal trampoline
ee4c6e2e72 linux-user: Add separate aarch64_be uname
1b214cd96a linux-user: Add support for big-endian aarch64
=== OUTPUT BEGIN ===
Checking PATCH 1/4: linux-user: Add support for big-endian aarch64...
Checking PATCH 2/4: linux-user: Add separate aarch64_be uname...
Checking PATCH 3/4: linux-user: Fix endianess of aarch64 signal trampoline...
ERROR: code indent should never use tabs
#26: FILE: linux-user/signal.c:1603:
+^I * mov x8,#__NR_rt_sigreturn; svc #0$
ERROR: code indent should never use tabs
#27: FILE: linux-user/signal.c:1604:
+^I * Since these are instructions they need to be put as little-endian$
ERROR: code indent should never use tabs
#28: FILE: linux-user/signal.c:1605:
+^I * regardless of target default or current CPU endianness.$
ERROR: code indent should never use tabs
#29: FILE: linux-user/signal.c:1606:
+^I */$
total: 4 errors, 0 warnings, 16 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/4: configure: Add aarch64_be-linux-user target...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH 0/4] Add aarch64_be-linux-user target, Michael Weiser, 2017/12/19
- [Qemu-devel] [PATCH 4/4] configure: Add aarch64_be-linux-user target, Michael Weiser, 2017/12/19
- [Qemu-devel] [PATCH 3/4] linux-user: Fix endianess of aarch64 signal trampoline, Michael Weiser, 2017/12/19
- [Qemu-devel] [PATCH 1/4] linux-user: Add support for big-endian aarch64, Michael Weiser, 2017/12/19
- [Qemu-devel] [PATCH 2/4] linux-user: Add separate aarch64_be uname, Michael Weiser, 2017/12/19
- Re: [Qemu-devel] [PATCH 0/4] Add aarch64_be-linux-user target, Laurent Vivier, 2017/12/19
- Re: [Qemu-devel] [PATCH 0/4] Add aarch64_be-linux-user target, Richard Henderson, 2017/12/20
- Re: [Qemu-devel] [PATCH 0/4] Add aarch64_be-linux-user target,
no-reply <=