Re: [Qemu-devel] [PATCH 1/3] input: add missing JIS keys to virtio input

[Eric Blake]

On 12/18/2017 07:24 AM, Miika S wrote:
> Signed-off-by: Miika S <address@hidden>
> ---
>   hw/input/virtio-input-hid.c | 7 +++++++
>   qapi/ui.json                | 2 +-
>   ui/keycodemapdb             | 2 +-
>   3 files changed, 9 insertions(+), 2 deletions(-)

When sending a multi-patch series, please remember to include the 0/3 
cover letter.  'git config format.coverletter auto' can make this task 
easier to remember.


>   
>   static const unsigned int keymap_button[INPUT_BUTTON__MAX] = {
> diff --git a/qapi/ui.json b/qapi/ui.json
> index 07b468f625..da4be505ac 100644
> --- a/qapi/ui.json
> +++ b/qapi/ui.json
> @@ -775,7 +775,7 @@
>               'left', 'up', 'down', 'right', 'insert', 'delete', 'stop', 
> 'again',
>               'props', 'undo', 'front', 'copy', 'open', 'paste', 'find', 'cut',
>               'lf', 'help', 'meta_l', 'meta_r', 'compose', 'pause',
> -            'ro', 'hiragana', 'henkan', 'yen',
> +            'ro', 'hiragana', 'muhenkan', 'henkan', 'katakanahiragana', 'yen',
>               'kp_comma', 'kp_equals', 'power', 'sleep', 'wake',
>               'audionext', 'audioprev', 'audiostop', 'audioplay', 'audiomute',
>               'volumeup', 'volumedown', 'mediaselect',

Missing documentation that calls out which enum values were added in 2.12.

> diff --git a/ui/keycodemapdb b/ui/keycodemapdb
> index 10739aa260..05dad417e9 160000
> --- a/ui/keycodemapdb
> +++ b/ui/keycodemapdb
> @@ -1 +1 @@
> -Subproject commit 10739aa26051a5d49d88132604539d3ed085e72e
> +Subproject commit 05dad417e9d0b37ee1fba33056d91a6b734b3357

Generally, the commit message body should call out that a submodule 
change alongside other changes is intentional.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org