[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] Vhost: no more leak QEMU virtual addresses
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] Vhost: no more leak QEMU virtual addresses to user backend |
Date: |
Thu, 21 Dec 2017 05:53:05 +0200 |
On Wed, Dec 20, 2017 at 04:07:41PM +0000, Stefan Hajnoczi wrote:
> On Tue, Dec 19, 2017 at 07:11:26PM +0100, Maxime Coquelin wrote:
> > Before this series, QEMU process virtual addresses are sent to the
> > user backend as user addresses.
> >
> > Passing these virtual addresses aren't useful, as the backend doesn't
> > direct access to QEMU address space.
> >
> > It does make sense however for kernel backend, which can access QEMU
> > address space.
> >
> > This series introduce a new enum set by the backend stating whether it
> > prefers using QEMU Virtual addresses or Guest physical addresses as
> > User address, and make vhost-user backend to use Guest physical
> > addresses.
> >
> > Maxime Coquelin (3):
> > vhost-user: rename VhostUserMemory userspace_addr field to user_addr
> > vhost: introduce backend's user address type
> > vhost-user: no more leak QEMU virtual addresses to user backend
> >
> > hw/virtio/vhost-backend.c | 1 +
> > hw/virtio/vhost-user.c | 6 ++++--
> > hw/virtio/vhost.c | 16 ++++++++++++----
> > include/hw/virtio/vhost-backend.h | 6 ++++++
> > 4 files changed, 23 insertions(+), 6 deletions(-)
> >
> > --
> > 2.14.3
> >
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
This makes make check fail. Any idea why?