Re: [Qemu-devel] [PATCH] target/m68k: add monitor.c

[Thomas Huth]

On 21.12.2017 08:56, Laurent Vivier wrote:
> Le 20/12/2017 à 22:22, Thomas Huth a écrit :
>> Am Wed, 20 Dec 2017 21:35:28 +0100
>> schrieb Laurent Vivier <address@hidden>:
>>
>>> This allows to use registers content in the monitor.
>>>
>>> Example:
>>>
>>>  BEFORE:
>>>   (qemu) print $d0
>>>   unknown register
>>>
>>>  AFTER:
>>>   (qemu) print $d0
>>>   0
>>>   (qemu) print $sr
>>>   0x2000
>>>   (qemu) x/10i $pc
>>>   0x40010a2a:  movew %sr,%d0
>>>   0x40010a2c:  oril #1792,%d0
>>>   0x40010a32:  movew %d0,%sr
>>>   0x40010a34:  movel %a0@,%d0
>>>   0x40010a36:  btst #3,%d0
>>>   0x40010a3a:  beqs 0x40010a26
>>>   0x40010a3c:  movew %sr,%d0
>>>   0x40010a3e:  andil #63743,%d0
>>>   0x40010a44:  movew %d0,%sr
>>>   0x40010a46:  rts
>>>
>>> Signed-off-by: Laurent Vivier <address@hidden>
>>> ---
>>>  target/m68k/Makefile.objs |  1 +
>>>  target/m68k/monitor.c     | 55
>>> +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 56
>>> insertions(+) create mode 100644 target/m68k/monitor.c
>>>
>>> diff --git a/target/m68k/Makefile.objs b/target/m68k/Makefile.objs
>>> index 39141ab93d..d143f20270 100644
>>> --- a/target/m68k/Makefile.objs
>>> +++ b/target/m68k/Makefile.objs
>>> @@ -1,3 +1,4 @@
>>>  obj-y += m68k-semi.o
>>>  obj-y += translate.o op_helper.o helper.o cpu.o fpu_helper.o
>>>  obj-y += gdbstub.o
>>> +obj-$(CONFIG_SOFTMMU) += monitor.o
>>> diff --git a/target/m68k/monitor.c b/target/m68k/monitor.c
>>> new file mode 100644
>>> index 0000000000..03d037ccab
>>> --- /dev/null
>>> +++ b/target/m68k/monitor.c
>>> @@ -0,0 +1,55 @@
>>> +/*
>>> + * QEMU monitor
>>> + *
>>> + * Copyright (c) 2003-2004 Fabrice Bellard
>>
>> Why this copyright line (and the non-GPL license code)?
> 
> I don't know. I've checked all the others monitor.c and they have the
> same header. An y suggestions?

Put at least your name in there - Fabrice did not write the new
monitor.c, but it was you instead!

Concerning the license text, this seems to be the MIT license. I guess
that's OK, just wanted to make you aware of it to consider whether you
rather want to use GPL instead or not.

 Thomas