Re: [Qemu-devel] [PATCH] hw/i386/vmport: fix missing definitions with x86_64-w64-mingw32

[Peter Maydell]

On 21 December 2017 at 22:55, Philippe Mathieu-Daudé <address@hidden> wrote:
>>> Fixes: 7299e1a411
>>>        ("hw/i386/vmport: replace fprintf() by trace events or LOG_UNIMP")
>>> Signed-off-by: Laurent Vivier <address@hidden>
>>
>> Looks to me like it'll be a bug for anything not configured
>> using the 'log' trace backend, rather than win32 specific.
>
> Sorry my bad, it seems I don't test enough lately, I'll try to do more
> testing, and somehow to reduce CI build time, more they last, less we
> rely on it, even with personal repositories.

It's unfortunate that trace.h pulls in qemu/log.h if you're
using the log backend, because it makes this particular
mistake easy; we've had quite a few instances of it...
(I could probably configure one of my test setups with a
different trace backend which would at least catch these
before they hit master.)

thanks
-- PMM