[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/6] xen: Add only xen-sysdev to dynamic sysb
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/6] xen: Add only xen-sysdev to dynamic sysbus device list |
Date: |
Fri, 22 Dec 2017 14:36:40 +0100 |
Hi,
On Sat, Nov 25, 2017 at 4:16 PM, Eduardo Habkost <address@hidden> wrote:
> There's no need to make the machine allow every possible sysbus
> device. We can now just add xen-sysdev to the allowed list.
>
> Cc: Stefano Stabellini <address@hidden>
> Cc: Anthony Perard <address@hidden>
> Cc: address@hidden
> Cc: Juergen Gross <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> Changes series v1 -> v2:
> * New patch added to series
> ---
> hw/xen/xen_backend.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c
> index 82380ea9ee..7445b506ac 100644
> --- a/hw/xen/xen_backend.c
> +++ b/hw/xen/xen_backend.c
> @@ -564,12 +564,7 @@ static void xen_set_dynamic_sysbus(void)
> ObjectClass *oc = object_get_class(machine);
> MachineClass *mc = MACHINE_CLASS(oc);
>
> - /*
> - * Emulate old mc->has_dynamic_sysbus=true assignment
> - *
> - *TODO: add only Xen devices to the list
> - */
> - machine_class_allow_dynamic_sysbus_dev(mc, TYPE_SYS_BUS_DEVICE);
> + machine_class_allow_dynamic_sysbus_dev(mc, TYPE_XENSYSDEV);
It looks like it's the last patch in the series without review. It
would be nice if a Xen maintainer could look at it, or test it, as I
dont know how to test it tbh.
Reviewed-by: Marc-André Lureau <address@hidden>
> }
>
> int xen_be_register(const char *type, struct XenDevOps *ops)
> --
> 2.13.6
>
>
--
Marc-André Lureau
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v2 5/6] xen: Add only xen-sysdev to dynamic sysbus device list,
Marc-André Lureau <=