[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 0/8] Enable passing pre-opened chardev socket FDs
From: |
Daniel P. Berrange |
Subject: |
[Qemu-devel] [PATCH v3 0/8] Enable passing pre-opened chardev socket FDs |
Date: |
Fri, 22 Dec 2017 13:45:19 +0000 |
This fixes a long standing problem that libvirt has with starting up QEMU.
We have to busy-wait retrying connect() on the QMP monitor socket until QEMU
finally creates & listens on it, but at same time must be careful to not wait
forever if QEMU exits.
This this patch series, libvirt can simply pass in a pre-opened UNIX domain
socket file descriptor, which it can immediately connect to with no busy-wait.
Changed in v3:
- Introduce qemu_strtoi & qemu_stroui functions. NB, patchew and
checkpatch.pl complain about this patch because it calls strtol,
but that is valid in this case.
- Split patchs up into more pieces to better separate each logical
change
- Introduce a new test/test-sockets.c to directly test the
SocketAddress FD handling, separately from chardev code.
- Add qapi docs for FD passing syntax
- Other misc fixes in tests
- Reduce code duplication when getting pre-opened FDs in
socket_connect/listen.
Changed in v2:
- Drop 'fdset' property / address kind, and use 'fd' for both CLI and HMP
- Add unit tests
Daniel P. Berrange (8):
cutils: add qemu_strtoi & qemu_strtoui parsers for int/unsigned int
types
sockets: move fd_is_socket() into common sockets code
sockets: pull code for testing IP availability out of specific test
sockets: strengthen test suite IP protocol availability checks
sockets: check that the named file descriptor is a socket
sockets: allow SocketAddress 'fd' to reference numeric file
descriptors
char: refactor parsing of socket address information
char: allow passing pre-opened socket file descriptor at startup
chardev/char-socket.c | 31 +-
chardev/char.c | 3 +
include/qemu/cutils.h | 4 +
include/qemu/sockets.h | 1 +
io/channel-util.c | 13 -
qapi/sockets.json | 7 +
tests/.gitignore | 1 +
tests/Makefile.include | 5 +-
tests/socket-helpers.c | 153 ++++++++++
tests/socket-helpers.h | 42 +++
tests/test-char.c | 47 ++-
tests/test-cutils.c | 653 +++++++++++++++++++++++++++++++++++++++++
tests/test-io-channel-socket.c | 72 +----
tests/test-sockets.c | 239 +++++++++++++++
util/cutils.c | 104 +++++++
util/qemu-sockets.c | 36 ++-
16 files changed, 1315 insertions(+), 96 deletions(-)
create mode 100644 tests/socket-helpers.c
create mode 100644 tests/socket-helpers.h
create mode 100644 tests/test-sockets.c
--
2.14.3
- [Qemu-devel] [PATCH v3 0/8] Enable passing pre-opened chardev socket FDs,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH v3 1/8] cutils: add qemu_strtoi & qemu_strtoui parsers for int/unsigned int types, Daniel P. Berrange, 2017/12/22
- [Qemu-devel] [PATCH v3 2/8] sockets: move fd_is_socket() into common sockets code, Daniel P. Berrange, 2017/12/22
- [Qemu-devel] [PATCH v3 3/8] sockets: pull code for testing IP availability out of specific test, Daniel P. Berrange, 2017/12/22
- [Qemu-devel] [PATCH v3 4/8] sockets: strengthen test suite IP protocol availability checks, Daniel P. Berrange, 2017/12/22
- [Qemu-devel] [PATCH v3 5/8] sockets: check that the named file descriptor is a socket, Daniel P. Berrange, 2017/12/22
- [Qemu-devel] [PATCH v3 7/8] char: refactor parsing of socket address information, Daniel P. Berrange, 2017/12/22
- [Qemu-devel] [PATCH v3 6/8] sockets: allow SocketAddress 'fd' to reference numeric file descriptors, Daniel P. Berrange, 2017/12/22
- [Qemu-devel] [PATCH v3 8/8] char: allow passing pre-opened socket file descriptor at startup, Daniel P. Berrange, 2017/12/22