Re: [Qemu-devel] [PATCH v3 0/8] Enable passing pre-opened chardev socket FDs

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v3 0/8] Enable passing pre-opened chardev socket 
FDs

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
67c8205ee6 char: allow passing pre-opened socket file descriptor at startup
4d76d8236d char: refactor parsing of socket address information
c994a8be65 sockets: allow SocketAddress 'fd' to reference numeric file 
descriptors
0b119aed04 sockets: check that the named file descriptor is a socket
46492af33f sockets: strengthen test suite IP protocol availability checks
6b8bfebc73 sockets: pull code for testing IP availability out of specific test
e8740ef3aa sockets: move fd_is_socket() into common sockets code
be50c154af cutils: add qemu_strtoi & qemu_strtoui parsers for int/unsigned int 
types

=== OUTPUT BEGIN ===
Checking PATCH 1/8: cutils: add qemu_strtoi & qemu_strtoui parsers for 
int/unsigned int types...
ERROR: consider using qemu_strtol in preference to strtol
#729: FILE: util/cutils.c:338:
+    lresult = strtol(nptr, &ep, base);

ERROR: consider using qemu_strtol in preference to strtol
#779: FILE: util/cutils.c:388:
+    lresult = strtol(nptr, &ep, base);

total: 2 errors, 0 warnings, 785 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/8: sockets: move fd_is_socket() into common sockets code...
Checking PATCH 3/8: sockets: pull code for testing IP availability out of 
specific test...
Checking PATCH 4/8: sockets: strengthen test suite IP protocol availability 
checks...
Checking PATCH 5/8: sockets: check that the named file descriptor is a socket...
Checking PATCH 6/8: sockets: allow SocketAddress 'fd' to reference numeric file 
descriptors...
Checking PATCH 7/8: char: refactor parsing of socket address information...
Checking PATCH 8/8: char: allow passing pre-opened socket file descriptor at 
startup...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden