[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/8] Small IPMI (and other) fixes
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH 0/8] Small IPMI (and other) fixes |
Date: |
Mon, 25 Dec 2017 10:43:21 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Sat, 12/23 08:36, Corey Minyard wrote:
> On 12/21/2017 05:10 PM, address@hidden wrote:
> > Hi,
> >
> > This series failed automatic build test. Please find the testing commands
> > and
> > their output below. If you have docker installed, you can probably
> > reproduce it
> > locally.
>
> The error here doesn't seem to have anything to do with these patches:
>
>
> > CC aarch64-softmmu/hw/virtio/virtio.o
> > CC aarch64-softmmu/hw/virtio/virtio-balloon.o
> > /tmp/qemu-test/src/hw/i386/vmport.c: In function 'vmport_ioport_read':
> > /tmp/qemu-test/src/hw/i386/vmport.c:81:9: error: implicit declaration of
> > function 'qemu_log_mask' [-Werror=implicit-function-declaration]
> > qemu_log_mask(LOG_UNIMP, "vmport: unknown command %x\n", command);
> > ^~~~~~~~~~~~~
> > /tmp/qemu-test/src/hw/i386/vmport.c:81:9: error: nested extern declaration
> > of 'qemu_log_mask' [-Werror=nested-externs]
> > /tmp/qemu-test/src/hw/i386/vmport.c:81:23: error: 'LOG_UNIMP' undeclared
> > (first use in this function)
> > qemu_log_mask(LOG_UNIMP, "vmport: unknown command %x\n", command);
> > ^~~~~~~~~
> > /tmp/qemu-test/src/hw/i386/vmport.c:81:23: note: each undeclared identifier
> > is reported only once for each function it appears in
> > cc1: all warnings being treated as errors
> > make[1]: *** [hw/i386/vmport.o] Error 1
> > make: *** [subdir-x86_64-softmmu] Error 2
> > make: *** Waiting for unfinished jobs....
> > /tmp/qemu-test/src/rules.mak:66: recipe for target 'hw/i386/vmport.o' failed
> > Makefile:387: recipe for target 'subdir-x86_64-softmmu' failed
>
> Am I missing something here?
>
It's a false positive because the master was broken at the time your series was
tested. Now it's fixed. Sorry for the noise. Patchew is being worked on to only
report errors when the merge base passes the same tests.
Fam
- [Qemu-devel] [PATCH 8/8] Add maintainer for the IPMI code, (continued)
- [Qemu-devel] [PATCH 8/8] Add maintainer for the IPMI code, minyard, 2017/12/07
- [Qemu-devel] [PATCH 3/8] ipmi: Add the platform event message command, minyard, 2017/12/07
- [Qemu-devel] [PATCH 6/8] vl.c: disallow command line fw cfg without opt/, minyard, 2017/12/07
- [Qemu-devel] [PATCH 4/8] ipmi: Fix macro issues, minyard, 2017/12/07
- [Qemu-devel] [PATCH 2/8] ipmi: Don't set the timestamp on add events that don't have it, minyard, 2017/12/07
- [Qemu-devel] [PATCH 1/8] ipmi: Fix SEL get/set time commands, minyard, 2017/12/07
- [Qemu-devel] [PATCH 7/8] ipmi: Allow BMC device properties to be set, minyard, 2017/12/07
- Re: [Qemu-devel] [PATCH 0/8] Small IPMI (and other) fixes, Corey Minyard, 2017/12/21
- Re: [Qemu-devel] [PATCH 0/8] Small IPMI (and other) fixes, no-reply, 2017/12/21