qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 09/10] linux-user: init_guest_space: Add a comment a


From: Luke Shumaker
Subject: [Qemu-devel] [PATCH 09/10] linux-user: init_guest_space: Add a comment about search strategy
Date: Thu, 28 Dec 2017 13:08:12 -0500

From: Luke Shumaker <address@hidden>

Signed-off-by: Luke Shumaker <address@hidden>
---
 linux-user/elfload.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 1b7583d659..7736ea2c3a 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -1936,6 +1936,10 @@ unsigned long init_guest_space(unsigned long host_start,
          * happen often.  Probably means we got unlucky and host
          * address space randomization put a shared library somewhere
          * inconvenient.
+         *
+         * This is probably a good strategy if host_start, but is
+         * probably a bad strategy if not, which means we got here
+         * because of trouble with ARM commpage setup.
          */
         munmap((void *)real_start, real_size);
         current_start += qemu_host_page_size;
-- 
2.15.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]