Re: [Qemu-devel] [PULL 0/8] tcg queued patches

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 0/8] tcg queued patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
0eee1c193b tcg: add cs_base and flags to -d exec output
0ae825a211 tcg: Allow 6 arguments to TCG helpers
b21be3b157 tcg: Add tcg_signed_cond
c4dfe7dcec tcg: Generalize TCGOp parameters
8a889b6b45 tcg: Dynamically allocate TCGOps
88b89d3f17 tcg: Remove TCGV_UNUSED* and TCGV_IS_UNUSED*
6bf49a6503 target/moxie: Fix tlb_fill
398432a8a8 target/*helper: don't check retaddr before calling cpu_restore_state

=== OUTPUT BEGIN ===
Checking PATCH 1/8: target/*helper: don't check retaddr before calling 
cpu_restore_state...
Checking PATCH 2/8: target/moxie: Fix tlb_fill...
Checking PATCH 3/8: tcg: Remove TCGV_UNUSED* and TCGV_IS_UNUSED*...
Checking PATCH 4/8: tcg: Dynamically allocate TCGOps...
ERROR: line over 90 characters
#64: FILE: include/qemu/queue.h:430:
+             (var) && ((prev_var) = (*(((struct headname 
*)((var)->field.tqe_prev))->tqh_last)), 1); \

ERROR: spaces prohibited around that ':' (ctx:WxW)
#538: FILE: tcg/tcg.h:575:
+    unsigned life   : 16;       /* 32 */
                     ^

total: 2 errors, 0 warnings, 520 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/8: tcg: Generalize TCGOp parameters...
ERROR: spaces prohibited around that ':' (ctx:WxW)
#114: FILE: tcg/tcg.h:570:
+    unsigned param1 : 4;        /* 12 */
                     ^

ERROR: spaces prohibited around that ':' (ctx:WxW)
#115: FILE: tcg/tcg.h:571:
+    unsigned param2 : 4;        /* 16 */
                     ^

ERROR: Macros with complex values should be enclosed in parenthesis
#123: FILE: tcg/tcg.h:583:
+#define TCGOP_CALLI(X)    (X)->param1

ERROR: Macros with complex values should be enclosed in parenthesis
#124: FILE: tcg/tcg.h:584:
+#define TCGOP_CALLO(X)    (X)->param2

total: 4 errors, 0 warnings, 92 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/8: tcg: Add tcg_signed_cond...
Checking PATCH 7/8: tcg: Allow 6 arguments to TCG helpers...
Checking PATCH 8/8: tcg: add cs_base and flags to -d exec output...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden